You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/13 11:03:46 UTC
[GitHub] [parquet-mr] bayandin opened a new pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.7.4
bayandin opened a new pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.7.4
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826#issuecomment-707679173
Is there any reason why we upgrading to the next maintenance version instead of the newest 2.7.7?
To be honest I would prefer to upgrade to the latest hadoop 2 release 2.10.1. Based on the semantic versioning it should not cause any issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] bayandin commented on pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.7.4
Posted by GitBox <gi...@apache.org>.
bayandin commented on pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826#issuecomment-707682107
> Is there any reason why we upgrading to the next maintenance version instead of the newest 2.7.7?
> To be honest I would prefer to upgrade to the latest hadoop 2 release 2.10.1. Based on the semantic versioning it should not cause any issues.
Since I have no experience neither with `parquet-mr` nor `hadoop` I suggested the safest (for my point of view) changes (the patch version bump). I don't mind to update it to `2.10.1` as you suggest 👍
And shall I add openjdk 15 to .travis.yml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.7.4
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826#issuecomment-707684831
I would prefer 2.10.1, thanks.
openjdk is clearly a separate topic. I would not upgrade to a non-LTS java release but this topic has to be discussed with the community on the dev list first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] bayandin edited a comment on pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.10.1
Posted by GitBox <gi...@apache.org>.
bayandin edited a comment on pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826#issuecomment-707682107
> Is there any reason why we upgrading to the next maintenance version instead of the newest 2.7.7?
> To be honest I would prefer to upgrade to the latest hadoop 2 release 2.10.1. Based on the semantic versioning it should not cause any issues.
Since I have no experience neither with `parquet-mr` nor `hadoop` I suggested the safest (for my point of view) changes (the patch version bump) which fixed build for me. I don't mind to update it to `2.10.1` as you suggest 👍
And shall I add openjdk 15 to .travis.yml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #826: PARQUET-1923: upgrade hadoop from 2.7.3 to 2.10.1
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #826:
URL: https://github.com/apache/parquet-mr/pull/826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org