You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2017/01/16 08:31:26 UTC

[jira] [Commented] (OAK-5230) AsyncIndexService should ensure that async lanes should confirm to naming convention

    [ https://issues.apache.org/jira/browse/OAK-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823612#comment-15823612 ] 

Alex Parvulescu commented on OAK-5230:
--------------------------------------

Patch looks good.
bq. Not sure if remove orphaned checkpoint logic in oak-run should account for this case
I'm not sure if this is a problem or not. I don't think we need to change anything there, but you might have more insight into this.

> AsyncIndexService should ensure that async lanes should confirm to naming convention
> ------------------------------------------------------------------------------------
>
>                 Key: OAK-5230
>                 URL: https://issues.apache.org/jira/browse/OAK-5230
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.5.18, 1.6
>
>         Attachments: OAK-5230-v1.patch
>
>
> OAK-4043 added support to remove unreferenced checkpoints. There it follows convention that all async names end with {{async}} e.g. async, fulltext-async etc
> This convention must be enforced in 
> * AsyncIndexerService
> * Oak#withAsyncIndexing(java.lang.String, long)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)