[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.

["Patrick Hunt (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-722:
-----------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

Patch looks good, verified for linux/cygwin.

> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-722
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.0
>         Environment: Mac OS X
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
>      Some shells may provide a builtin echo command which is similar or identical to this utility.  Most notably, the builtin echo in sh(1) does not accept
>      the -n option.  Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira