[GitHub] [kibble] Humbedooh commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox <gi...@apache.org>]

Humbedooh commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r643063549



##########
File path: kibble/scanners/base.py
##########
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any
+
+
+class BaseScanner:
+    """Abstract, base class for all scanners"""
+
+    # pylint: disable=too-few-public-methods
+    def __init__(self, **kwargs):
+        self.log = logging.getLogger(__name__)
+
+    def _persist(self, payload: Any):  # pylint: disable=no-self-use
+        """Persists data to database. Should be implemented per scanner."""

Review comment:
       as of current ES versions, you can't have different document types in the same DB.
   So it would have to be one document type per index, which is what we also did with Kibble 1, for instance you have kibble_mail, kibble_code_commit, kibble_issue etc - one per general data type. You can do more generalized queries across indices, but usually we just deal with one type at a time, so having multiple indices is not an issue...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org