You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/12/19 19:08:43 UTC

[jira] Created: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

[hbase] scanner truncates resultset when > 1 column families
------------------------------------------------------------

                 Key: HADOOP-2467
                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
             Project: Hadoop
          Issue Type: Bug
          Components: contrib/hbase
            Reporter: stack


Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2467:
--------------------------

    Fix Version/s: 0.16.0
           Status: Patch Available  (was: Open)

Passes tests locally.  Trying hudson.

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2467:
--------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed.

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2467:
--------------------------

    Status: Patch Available  (was: In Progress)

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553568 ] 

Hadoop QA commented on HADOOP-2467:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12371997/scanner.patch
against trunk revision r605675.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1399/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1399/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1399/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1399/console

This message is automatically generated.

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2467:
--------------------------

    Attachment: scanner.patch

Problem was in filters.  If multiple column families, the same filter instance would be used by all store scanners.  For filters that have state, e.g. WhileMatchRowFilter, we don't want the state of one store scanner effecting the scanning over in another store.  Fix was to make a filter instance per store involved in a particular scanning.

Below is commit message:

{code}
M  src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestScanner2.java
    (testScanningMultipleFamiliesOfDifferentVintage): Added.
M  src/contrib/hbase/src/test/org/apache/hadoop/hbase/HBaseTestCase.java
    Add javadoc.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreFile.java
    Add change that was supposed to have been committed for HADOOP-2407.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
    Spacing.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreKey.java
    (COLUMN_FAMILY_DELIMITER): Added.
    (getColonOffset): changed implementation to make it run faster.
    (compareTo): Reformatted.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HTable.java
    If no timestamp, use HConstants.LATEST_TIMESTAMP rather than
    current time so we get the newest version that exists.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMaster.java
    Was missing a '{] in toString.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
    (checkColumn): Remove double Text instantiation.
    Creating scanners for a store, make new instance if > 1 family
    so state set in one families scanning does not effect the 
    scanning of another.
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/util/Writables.java
    Add clone local until HADOOP-2469 gets applied.
{code}

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553583 ] 

Hadoop QA commented on HADOOP-2467:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12371997/scanner.patch
against trunk revision r605675.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1401/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1401/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1401/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1401/console

This message is automatically generated.

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2467:
--------------------------

    Status: In Progress  (was: Patch Available)

I ran the failed test locally, TestHBaseCluster, on two different platforms and it passed.  Its odd that assert 245 of 1000 failed. Retry.

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2467) [hbase] scanner truncates resultset when > 1 column families

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HADOOP-2467:
-----------------------------

    Assignee: stack

> [hbase] scanner truncates resultset when > 1 column families
> ------------------------------------------------------------
>
>                 Key: HADOOP-2467
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2467
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.16.0
>
>         Attachments: scanner.patch
>
>
> Scanner will close when first of n families runs out of results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.