You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:55:47 UTC
Review Request 65862: Windows: Removed signal macro in
`checks/checker_process.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65862/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
Repository: mesos
Description
-------
`checker_process.cpp` used signals to determine if the task has been
killed. This logic has been #ifdef'd out, since signals aren't
supported on Windows. A different implemention will be needed when
nested command checks work on Windows.
Diffs
-----
src/checks/checker_process.cpp cf9ec053946e620eb36e92d647ab864c4e88d506
Diff: https://reviews.apache.org/r/65862/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65862: Windows: Removed signal macro in
`checks/checker_process.cpp`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65862/#review198568
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On March 1, 2018, 1:55 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65862/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 1:55 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `checker_process.cpp` used signals to determine if the task has been
> killed. This logic has been #ifdef'd out, since signals aren't
> supported on Windows. A different implemention will be needed when
> nested command checks work on Windows.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp cf9ec053946e620eb36e92d647ab864c4e88d506
>
>
> Diff: https://reviews.apache.org/r/65862/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>