You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/05 14:33:19 UTC
[GitHub] [doris] yixiutt opened a new pull request, #14836: [bugfix](compaction) fix promotion size bug
yixiutt opened a new pull request, #14836:
URL: https://github.com/apache/doris/pull/14836
# Proposed changes
tablet_promotion_size can modify by all tablet cause cumulative_compaction_policy is global.
fix: add a member for tablet to record promotion size
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14836:
URL: https://github.com/apache/doris/pull/14836#issuecomment-1339161049
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14836:
URL: https://github.com/apache/doris/pull/14836#issuecomment-1340282786
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14836:
URL: https://github.com/apache/doris/pull/14836#issuecomment-1337539527
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.28 seconds
load time: 482 seconds
storage size: 17123356312 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221205150703_clickbench_pr_58127.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14836:
URL: https://github.com/apache/doris/pull/14836#discussion_r1039681888
##########
be/src/olap/page_cache.cpp:
##########
@@ -64,7 +64,7 @@ bool StoragePageCache::lookup(const CacheKey& key, PageCacheHandle* handle,
void StoragePageCache::insert(const CacheKey& key, const Slice& data, PageCacheHandle* handle,
segment_v2::PageTypePB page_type, bool in_memory) {
- auto deleter = [](const doris::CacheKey& key, void* value) { delete[] (uint8_t*)value; };
+ auto deleter = [](const doris::CacheKey& key, void* value) { delete[](uint8_t*) value; };
Review Comment:
warning: parameter 'key' is unused [misc-unused-parameters]
```suggestion
auto deleter = [](const doris::CacheKey& /*key*/, void* value) { delete[](uint8_t*) value; };
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #14836:
URL: https://github.com/apache/doris/pull/14836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14836: [bugfix](compaction) fix promotion size bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14836:
URL: https://github.com/apache/doris/pull/14836#issuecomment-1337503107
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org