You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/03 22:20:38 UTC
[GitHub] [beam] robertwb opened a new pull request, #17536: [BEAM-14403] Allow Prime to be used with legacy workers.
robertwb opened a new pull request, #17536:
URL: https://github.com/apache/beam/pull/17536
Defer this decision to the service rather than the SDK.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #17536: [BEAM-14403] Allow Prime to be used with legacy workers.
Posted by GitBox <gi...@apache.org>.
robertwb merged PR #17536:
URL: https://github.com/apache/beam/pull/17536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #17536: [BEAM-14403] Allow Prime to be used with legacy workers.
Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #17536:
URL: https://github.com/apache/beam/pull/17536#issuecomment-1116726429
Do we have logic in place in router to block unsupported pipeline https://github.com/apache/beam/blob/25d14a7f12a3388cc3a437a10096c804a6e14c1e/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L2349
And there might be regression from the sdk container image pick, for example b/228894537 is opened so that we don't rely on SDK to make a pick based on useUnifiedWorker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #17536: [BEAM-14403] Allow Prime to be used with legacy workers.
Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #17536:
URL: https://github.com/apache/beam/pull/17536#issuecomment-1116728881
LGTM for this change since the if anything needs to be fixed it'll be on service side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #17536: [BEAM-14403] Allow Prime to be used with legacy workers.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17536:
URL: https://github.com/apache/beam/pull/17536#issuecomment-1116786654
> Do we have logic in place in router to block unsupported pipeline
This means that for unsupported features one may have to pass a (possibly redundant) `use_runner_v2` as well as `enable_prime`.
> And there might be regression from the sdk container image pick, for example b/228894537 is opened so that we don't rely on SDK to make a pick based on useUnifiedWorker.
The SDK supplies the appropriate container as part of its environment config(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org