You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/03/12 22:46:07 UTC
[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12668
to look at the new patch set (#2).
Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................
IMPALA-8304: Generate JUnitXML if a command run by CMake fails
This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself.
Testing:
- Verified it does not impact a successful build (including with
ccache and/or distcc).
- Verified it generates JUnitXML for C++ and Java compilation
failures.
- Verified it works on Centos 6.
Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
3 files changed, 56 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/2
--
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>