[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3688: ARTEMIS-3414 Disable OpenWire advisory support as default created configuration on CLI

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3688:
URL: https://github.com/apache/activemq-artemis/pull/3688#discussion_r684189086



##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##########
@@ -283,6 +283,12 @@
    @Option(name = "--staticCluster", description = "Cluster node connectors list, separated by comma: Example \"tcp://server:61616,tcp://server2:61616,tcp://server3:61616\"")
    String staticNode;
 
+   @Option(name = "--support-advisory", description = "Set supportAdvisory=true for the main 'artemis' acceptor on OPENWIRE protocol (Default: false)")

Review comment:
       On Boolean values, the defaults are always false.
   
   instead, please change the text as... 
   
   
   description = "If you use --support-advisory, the generated configuration will allow advisories for the openwire protocol"
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org