[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #7868: [SQL Lab] Fix TableSelector perf for large option sets

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #7868: [SQL Lab] Fix TableSelector perf for large option sets
URL: https://github.com/apache/incubator-superset/pull/7868#discussion_r303193188
 
 

 ##########
 File path: superset/assets/src/components/TableSelector.jsx
 ##########
 @@ -277,10 +274,10 @@ export default class TableSelector extends React.PureComponent {
         name="select-table"
         ref="selectTable"
         isLoading={this.state.tableLoading}
+        ignoreAccents={false}
         placeholder={t('Select table or type table name')}
         autosize={false}
         onChange={this.changeTable}
-        filterOptions={this.state.filterOptions}
 
 Review comment:
   there is a unit test for filterOptions prop. are you sure to remove it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org