You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Daniel Dekany <dd...@apache.org> on 2023/01/06 19:29:33 UTC
[VOTE] Release Apache FreeMarker 2.3.32
Hi all,
Please vote on releasing FreeMarker 2.3.32!
As there were changes in the last few days, don't skip testing with
your dependent projects, even if you already did it recently.
Release Notes:
https://freemarker.apache.org/builds/2.3.32-voting/versions_2_3_32.html
Before proceed, you should know that FreeMarker 2.3.x, for a long
time, always releases a normal and a "gae" variant on the same time,
which are technically two independent source trees (Git branches). The
"gae" variant contains a few small modification in the Java source
code to be Google App Engine compliant, and has freemarker-gae as the
Maven artifact name. Otherwise the normal and the "gae" branches are
identical. Hence they will be voted on together.
The commits to be voted upon are:
- Normal (non-gae) variant:
https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=b28f1f17832d22c12576fa2c978a3bd42f84f9a9
Commit hash: b28f1f17832d22c12576fa2c978a3bd42f84f9a9
- "gae" variant:
https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8050768b35b0dab051e4eb18a083b239e4e104bd
Commit hash: 8050768b35b0dab051e4eb18a083b239e4e104bd
The artifacts to be voted upon are located here:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
where the source release artifacts are:
- Normal (non-gae) variant:
apache-freemarker-2.3.32-src.tar.gz
- "gae" variant:
apache-freemarker-gae-2.3.32-src.tar.gz
See the README.md inside them for build instructions!
The release artifacts are signed with the following key:
https://people.apache.org/keys/committer/ddekany.asc
For convenience, we also provide binaries, which also need to be checked:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/binaries/
and Maven artifacts in the ASF Staging Repository:
https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.32/
Please try out the package and vote!
The vote is open for a minimum of 72 hours or until the necessary number of
votes (3 binding +1s) is reached.
[ ] +1 Release this package as Apache FreeMarker 2.3.32
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Please add "(binding)" if your vote is binding.
--
Thanks,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 06/01/2023 à 20:29, Daniel Dekany a écrit :
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.32-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.32-src.tar.gz
>
> See the README.md inside them for build instructions!
Hi Daniel,
Following instruction in the README, in OFBiz trunk build.gradle adding this repository
maven {
url "https://repository.apache.org/content/repositories/staging/"
}
and using
implementation 'org.freemarker:freemarker:2.3.32'
as far as I can tell all seems to go well
+1 binding
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Daniel Dekany <dd...@apache.org>.
As I did the most release work, of course I tested the standard things
(clean build, etc.), and also tested if docgen and fmpp generates exactly
the same output with the new version.
+1 (binding)
On Fri, Jan 6, 2023 at 8:29 PM Daniel Dekany <dd...@apache.org> wrote:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.32!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.32-voting/versions_2_3_32.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> Commit hash: b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8050768b35b0dab051e4eb18a083b239e4e104bd
> Commit hash: 8050768b35b0dab051e4eb18a083b239e4e104bd
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.32-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.32-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/binaries/
> and Maven artifacts in the ASF Staging Repository:
>
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.32/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.32
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Daniel Dekany <dd...@apache.org>.
Anyone is planning to do more testing? Because then I will wait for that.
Otherwise I will finish the release process (in a few days).
On Fri, Jan 6, 2023 at 8:29 PM Daniel Dekany <dd...@apache.org> wrote:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.32!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.32-voting/versions_2_3_32.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> Commit hash: b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8050768b35b0dab051e4eb18a083b239e4e104bd
> Commit hash: 8050768b35b0dab051e4eb18a083b239e4e104bd
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.32-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.32-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/binaries/
> and Maven artifacts in the ASF Staging Repository:
>
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.32/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.32
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Woonsan Ko <wo...@apache.org>.
+1 (binding)
- signatures verified
- build OKs (ant; ant test, ant javadoc, ant manualOffline)
- basic tests OK in my apps with locally installed maven jar
- documentation looks good!
Regards,
Woonsan
On Sat, Jan 7, 2023 at 4:29 AM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.32!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.32-voting/versions_2_3_32.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> Commit hash: b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8050768b35b0dab051e4eb18a083b239e4e104bd
> Commit hash: 8050768b35b0dab051e4eb18a083b239e4e104bd
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.32-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.32-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.32/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.32
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Christoph Rüger <c....@synesty.com>.
+1
Just did regression testing with our test suite. No issues.
Am Fr., 6. Jan. 2023 um 20:29 Uhr schrieb Daniel Dekany <ddekany@apache.org
>:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.32!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.32-voting/versions_2_3_32.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> Commit hash: b28f1f17832d22c12576fa2c978a3bd42f84f9a9
> - "gae" variant:
>
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8050768b35b0dab051e4eb18a083b239e4e104bd
> Commit hash: 8050768b35b0dab051e4eb18a083b239e4e104bd
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.32-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.32-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.32/binaries/
> and Maven artifacts in the ASF Staging Repository:
>
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.32/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.32
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>
--
Christoph Rüger, Geschäftsführer
Synesty <https://synesty.com/> - Anbinden und Automatisieren ohne
Programmieren
--
Synesty GmbH
Berggasse 1
07745 Jena
Tel.: +49 3641 5596493Internet:
https://synesty.com <https://synesty.com>
Informationen zum Datenschutz:
https://synesty.com/datenschutz <https://synesty.com/datenschutz>
Geschäftsführer: Christoph Rüger
Unternehmenssitz: Jena
Handelsregister B
beim Amtsgericht: Jena
Handelsregister-Nummer: HRB 508766
Ust-IdNr.:
DE287564982
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by Daniel Dekany <da...@gmail.com>.
Regarding versioning. When the versioning policy of FreeMarker was
established, we did not know about SemVer yet. Maybe it wasn't even a thing
back then. Now we do releases with the same policy for 20+ years, and
changing that is also confusing. Like we spring 2.3.xx for a very long
time, and if we suddenly step up to 2.4.0, people will expect that it's
some big deal.
Another issue is that SemVer is not a good fit for all kind of projects.
For example for us the 3rd version number almost always would be 0. (If
it's not, then we just had a broken release, so we had to re-release
immediately.) Also, in languages, and let's take Python 2 and 3 as an
example, the major (1st) version increase means some huge historical
cleanup.
Also, I do plan to have a 2.4.0, but that will slightly break backward
compatibility. I want to get rid of the gae VS normal distinction, and
maybe get rid of some really archaic things that almost nobody uses. In the
FreeMarke version policy that's exactly what 2nd version number increases
are for, and I believe many languages do the same. It's for changes where
most users will have to do nothing, except reviewing the log carefully, to
see if they are the unlucky. Now, if we call that version 3.0.0, then
what's the thing that we already call FM 3 will be called? (Yes, I know,
probablz will be never released, but still... the branch exists, the topic
exists.)
On Mon, Jan 9, 2023 at 6:18 AM David E Jones <de...@dejc.com> wrote:
>
> > On Jan 6, 2023, at 11:29, Daniel Dekany <dd...@apache.org> wrote:
> >
> > Please vote on releasing FreeMarker 2.3.32!
>
> I tested the update with and without the latest feature version constant,
> all my tests pass.
>
> On a side note, while testing I was looking at the version number and
> thinking about semantic versioning. I don’t remember any discussions about
> this but there probably have been some. For a release with new features the
> minor version number would be bumped (the 2nd number), leaving the final
> number as the patch version for bug fixes only. In other words this would
> be 2.4.0 because of minor new features (but nothing not backward compatible
> so no need to bump the first/major version number). Semantic versioning is
> an interesting pattern, not necessary by any means to roughly communicate
> what is going on with a new release versus the prior, but is a clear way of
> communicating the most important parts of a release (bug fix only? new
> features? backward compatible?). This is not related to the vote for this
> particular release, just something related to releases that if others are
> interested might be worth discussing.
>
> +1 (binding)
>
> -David
>
>
--
Best regards,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.32
Posted by David E Jones <de...@dejc.com>.
> On Jan 6, 2023, at 11:29, Daniel Dekany <dd...@apache.org> wrote:
>
> Please vote on releasing FreeMarker 2.3.32!
I tested the update with and without the latest feature version constant, all my tests pass.
On a side note, while testing I was looking at the version number and thinking about semantic versioning. I don’t remember any discussions about this but there probably have been some. For a release with new features the minor version number would be bumped (the 2nd number), leaving the final number as the patch version for bug fixes only. In other words this would be 2.4.0 because of minor new features (but nothing not backward compatible so no need to bump the first/major version number). Semantic versioning is an interesting pattern, not necessary by any means to roughly communicate what is going on with a new release versus the prior, but is a clear way of communicating the most important parts of a release (bug fix only? new features? backward compatible?). This is not related to the vote for this particular release, just something related to releases that if others are interested might be worth discussing.
+1 (binding)
-David