You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/16 08:03:10 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #15967: [feature](agg)support two level-hash map in aggregation node
mrhhsg opened a new pull request, #15967:
URL: https://github.com/apache/doris/pull/15967
# Proposed changes
Related PR: #14480
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15967:
URL: https://github.com/apache/doris/pull/15967#discussion_r1070935014
##########
be/src/vec/common/hash_table/partitioned_hash_map.h:
##########
@@ -46,8 +46,34 @@
return *lookup_result_get_mapped(it);
}
+
+ template <typename Func>
+ void for_each_mapped(Func&& func) {
+ for (auto& v : *this) {
+ func(v.get_second());
+ }
+ }
};
template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
using PartitionedHashMap =
PartitionedHashMapTable<HashMap<Key, Mapped, Hash, PartitionedHashTableGrower<>>>;
+
+template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
+using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
+
+template <typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<PHPartitionedHashMap<Key, Mapped, Hash>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<PHPartitionedHashMap<Key, Mapped, Hash>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_map.h:
##########
@@ -46,8 +46,34 @@
return *lookup_result_get_mapped(it);
}
+
+ template <typename Func>
+ void for_each_mapped(Func&& func) {
+ for (auto& v : *this) {
+ func(v.get_second());
+ }
+ }
};
template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
using PartitionedHashMap =
PartitionedHashMapTable<HashMap<Key, Mapped, Hash, PartitionedHashTableGrower<>>>;
+
+template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
+using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
+
+template <typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<PHPartitionedHashMap<Key, Mapped, Hash>> {
Review Comment:
warning: use of undeclared identifier 'PHPartitionedHashMap' [clang-diagnostic-error]
```cpp
struct HashTableTraits<PHPartitionedHashMap<Key, Mapped, Hash>> {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_map.h:
##########
@@ -46,8 +46,34 @@ class PartitionedHashMapTable : public PartitionedHashTable<ImplTable> {
return *lookup_result_get_mapped(it);
}
+
+ template <typename Func>
+ void for_each_mapped(Func&& func) {
+ for (auto& v : *this) {
+ func(v.get_second());
+ }
+ }
};
template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
using PartitionedHashMap =
PartitionedHashMapTable<HashMap<Key, Mapped, Hash, PartitionedHashTableGrower<>>>;
+
+template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
+using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
Review Comment:
warning: use of undeclared identifier 'PHHashMap' [clang-diagnostic-error]
```cpp
using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_map.h:
##########
@@ -46,8 +46,34 @@
return *lookup_result_get_mapped(it);
}
+
+ template <typename Func>
+ void for_each_mapped(Func&& func) {
+ for (auto& v : *this) {
+ func(v.get_second());
+ }
+ }
};
template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
using PartitionedHashMap =
PartitionedHashMapTable<HashMap<Key, Mapped, Hash, PartitionedHashTableGrower<>>>;
+
+template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
+using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
+
+template <typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<PHPartitionedHashMap<Key, Mapped, Hash>> {
+ static constexpr bool is_phmap = true;
+ static constexpr bool is_parallel_phmap = false;
+ static constexpr bool is_string_hash_table = false;
+ static constexpr bool is_partitioned_table = true;
+};
+
+template <template <typename> class Derived, typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<Derived<PHPartitionedHashMap<Key, Mapped, Hash>>> {
Review Comment:
warning: use of undeclared identifier 'PHPartitionedHashMap' [clang-diagnostic-error]
```cpp
struct HashTableTraits<Derived<PHPartitionedHashMap<Key, Mapped, Hash>>> {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_map.h:
##########
@@ -46,8 +46,34 @@
return *lookup_result_get_mapped(it);
}
+
+ template <typename Func>
+ void for_each_mapped(Func&& func) {
+ for (auto& v : *this) {
+ func(v.get_second());
+ }
+ }
};
template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
using PartitionedHashMap =
PartitionedHashMapTable<HashMap<Key, Mapped, Hash, PartitionedHashTableGrower<>>>;
+
+template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>>
+using PHPartitionedHashMap = PartitionedHashMapTable<PHHashMap<Key, Mapped, Hash>>;
+
+template <typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<PHPartitionedHashMap<Key, Mapped, Hash>> {
+ static constexpr bool is_phmap = true;
+ static constexpr bool is_parallel_phmap = false;
+ static constexpr bool is_string_hash_table = false;
+ static constexpr bool is_partitioned_table = true;
+};
+
+template <template <typename> class Derived, typename Key, typename Mapped, typename Hash>
+struct HashTableTraits<Derived<PHPartitionedHashMap<Key, Mapped, Hash>>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<Derived<PHPartitionedHashMap<Key, Mapped, Hash>>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_table.h:
##########
@@ -398,6 +401,17 @@
}
}
+ void ALWAYS_INLINE prefetch_by_hash(size_t hash_value) {
+ if constexpr (HashTableTraits<Impl>::is_phmap) {
Review Comment:
warning: template argument for non-type template parameter must be an expression [clang-diagnostic-error]
```cpp
if constexpr (HashTableTraits<Impl>::is_phmap) {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_table.h:
##########
@@ -517,17 +559,26 @@
auto it = level0_sub_table.begin();
- /// It is assumed that the zero key (stored separately) is first in iteration order.
- if (it != level0_sub_table.end() && it.get_ptr()->is_zero(level0_sub_table)) {
- insert(it->get_value());
- ++it;
- }
+ if constexpr (HashTableTraits<Impl>::is_phmap) {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
if constexpr (HashTableGrower<Impl>::is_phmap) {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_table.h:
##########
@@ -398,6 +401,17 @@ class PartitionedHashTable : private boost::noncopyable, Impl::Hash {
}
}
+ void ALWAYS_INLINE prefetch_by_hash(size_t hash_value) {
+ if constexpr (HashTableTraits<Impl>::is_phmap) {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
if constexpr (HashTableGrower<Impl>::is_phmap) {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/partitioned_hash_table.h:
##########
@@ -517,17 +559,26 @@
auto it = level0_sub_table.begin();
- /// It is assumed that the zero key (stored separately) is first in iteration order.
- if (it != level0_sub_table.end() && it.get_ptr()->is_zero(level0_sub_table)) {
- insert(it->get_value());
- ++it;
- }
+ if constexpr (HashTableTraits<Impl>::is_phmap) {
Review Comment:
warning: template argument for non-type template parameter must be an expression [clang-diagnostic-error]
```cpp
if constexpr (HashTableTraits<Impl>::is_phmap) {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/ph_hash_map.h:
##########
@@ -27,11 +27,13 @@ ALWAYS_INLINE inline auto lookup_result_get_mapped(std::pair<const Key, Mapped>*
return &(it->second);
}
-template <typename Key, typename Mapped, typename Hash = DefaultHash<Key>,
+template <typename Key, typename Mapped, typename HashMethod = DefaultHash<Key>,
bool use_parallel = false>
class PHHashMap : private boost::noncopyable {
Review Comment:
warning: expected class name [clang-diagnostic-error]
```cpp
class PHHashMap : private boost::noncopyable {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1407702619
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1407924442
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1384748809
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1387431369
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.11 seconds
load time: 490 seconds
storage size: 17122740053 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118171209_clickbench_pr_83335.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #15967:
URL: https://github.com/apache/doris/pull/15967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1386817053
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1384735246
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1407879876
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1407620734
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1383722243
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1386284330
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on code in PR #15967:
URL: https://github.com/apache/doris/pull/15967#discussion_r1090113898
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
static constexpr bool is_phmap = false;
- static constexpr bool is_parallel_phmap = false;
static constexpr bool is_string_hash_table = true;
+ static constexpr bool is_partitioned_table = false;
};
template <template <typename> class Derived, typename TMapped, typename Allocator>
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<Derived<StringHashMap<TMapped, Allocator>>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
Review Comment:
warning: template argument for non-type template parameter must be an expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@ class StringHashTable : private boost::noncopyable {
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: explicit specialization of undeclared template struct 'HashTableTraits' [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashTable<SubMaps>> {
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<StringHashTable<SubMaps>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@ class StringHashMap : public StringHashTable<StringHashMapSubMaps<TMapped, Alloc
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean 'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<StringHashMap<TMapped, Allocator>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower' declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
static constexpr bool is_phmap = false;
- static constexpr bool is_parallel_phmap = false;
static constexpr bool is_string_hash_table = true;
+ static constexpr bool is_partitioned_table = false;
};
template <template <typename> class Derived, typename TMapped, typename Allocator>
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
Review Comment:
warning: template argument for non-type template parameter must be an expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: template argument for non-type template parameter must be an expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashTable<SubMaps>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15967: [feature](agg)support two level-hash map in aggregation node
Posted by github-actions.
github-actions[bot] commented on PR #15967:
URL: https://github.com/apache/doris/pull/15967#issuecomment-1407924385
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org