You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/11 16:34:36 UTC

[GitHub] [superset] etr2460 opened a new issue #13078: Certification Icons not shown in metric popover select

etr2460 opened a new issue #13078:
URL: https://github.com/apache/superset/issues/13078


   ## Screenshot
   ![image-2021-02-02-12-38-58-762](https://user-images.githubusercontent.com/7409244/107666682-a0b8b400-6c43-11eb-83ad-de1e2da4fad9.png)
   
   
   ## Description
   For the same search query, we show certification icons for the metrics in the dataset sidebar, but not in the metric popover select. I believe this is a regression from previous behavior where we showed the certification icons in both places: see original implementation here: https://github.com/apache-superset/superset-ui/pull/748 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zuzana-vej closed issue #13078: Certification Icons not shown in metric popover select

Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #13078:
URL: https://github.com/apache/superset/issues/13078


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #13078: Certification Icons not shown in metric popover select

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13078:
URL: https://github.com/apache/superset/issues/13078#issuecomment-777682962


   thanks for reporting! I believe we lost the certification icon for a while already sice AntD migration? We will bring it back soon.🙏 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #13078: Certification Icons not shown in metric popover select

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13078:
URL: https://github.com/apache/superset/issues/13078#issuecomment-777682962


   thanks for reporting! I believe we lost the certification icon for a while already. 
   wasn't familiar with certification feature before so I missed it.  we will bring it back soon! 
   
   cc: @kgabryje 🙏 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zuzana-vej commented on issue #13078: Certification Icons not shown in metric popover select

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #13078:
URL: https://github.com/apache/superset/issues/13078#issuecomment-808496235


   resolved by the above linked PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org