You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/07/31 18:16:14 UTC

[jira] Created: (CASSANDRA-329) combine thrift slice methods

combine thrift slice methods
----------------------------

                 Key: CASSANDRA-329
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
             Fix For: 0.4




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-329:
-------------------------------------

    Attachment: 329-thrift-v2.patch

merges more aggressively

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741346#action_12741346 ] 

Hudson commented on CASSANDRA-329:
----------------------------------

Integrated in Cassandra #163 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/163/])
    Combine thrift slice methods.  Now we have one get() method, one get_slice(), and one get_count().
patch by jbellis; reviewed by Evan Weaver for 


> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-329) combine thrift slice methods

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-329:
-------------------------------------

    Component/s: Core

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740621#action_12740621 ] 

Jonathan Ellis commented on CASSANDRA-329:
------------------------------------------

332 is committed now and there is a conflict.  will rebase.

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741076#action_12741076 ] 

Jonathan Ellis commented on CASSANDRA-329:
------------------------------------------

just had to move a comment around in a merge conflict in the new, btw.

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-329:
-------------------------------------

    Attachment: 0002-v2.patch

rebased.  so the relevant patches are now 0001 and 0002-v2

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-329:
-------------------------------------

    Attachment: 329-thrift.patch

proposed thrift changes

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741095#action_12741095 ] 

Evan Weaver commented on CASSANDRA-329:
---------------------------------------

ship it!

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-329:
-------------------------------------

    Attachment: 0002-make-new-thrift-work.txt
                0001-CASSANDRA-329-thrift.txt

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741075#action_12741075 ] 

Evan Weaver commented on CASSANDRA-329:
---------------------------------------

Ship it! on the old version. Trying the new.

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 0002-v2.patch, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-329) combine thrift slice methods

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738535#action_12738535 ] 

Jonathan Ellis commented on CASSANDRA-329:
------------------------------------------

final patches attached.

now we have one (count it! one!) get() method, one get_slice(), and one get_count().

huzzah.

> combine thrift slice methods
> ----------------------------
>
>                 Key: CASSANDRA-329
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-329
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-329-thrift.txt, 0002-make-new-thrift-work.txt, 329-thrift-v2.patch, 329-thrift.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.