You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/19 01:45:07 UTC
[GitHub] [lucene] mocobeta opened a new pull request #394: LUCENE-9997: write release revision to system temp dir
mocobeta opened a new pull request #394:
URL: https://github.com/apache/lucene/pull/394
Suggested at:
- https://github.com/apache/lucene/pull/382#discussion_r729615274
- https://issues.apache.org/jira/browse/LUCENE-9997?focusedCommentId=17430157&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17430157
`/tmp` should work on any standard linux filesystems. I think the fixed path is okay.
https://superuser.com/questions/332610/where-is-the-temporary-directory-in-linux/332616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #394: LUCENE-9997: write release revision to system temp dir
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #394:
URL: https://github.com/apache/lucene/pull/394#issuecomment-947141245
The `rev.txt` file is used to reuse the git revision on the previous run when `--no-prepare` option is passed.
https://github.com/apache/lucene/blob/c77e9ddf93ae872ba6556d39c48a0a32e31e91b1/dev-tools/scripts/buildAndPushRelease.py#L398-L402
I'm not sure what is the use-cases of this, but if it's needed (for convenience?) we need an explicitly fixed path and shouldn't clean up the file after the first run. It's actually not a "temporary" file...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #394: LUCENE-9997: write release revision to system temp dir
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #394:
URL: https://github.com/apache/lucene/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #394: LUCENE-9997: write release revision to system temp dir
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #394:
URL: https://github.com/apache/lucene/pull/394#issuecomment-946429811
Thanks Tomoko. What is this file for though? Is it really needed at all (can't it be a variable)? It'd also help to use Python's temporary-file facilities so that it's system-agnostic (I don't believe this will even run on Windows properly, but we can try not to make it worse).
https://docs.python.org/3/library/tempfile.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org