[GitHub] [geode] mivanac commented on a change in pull request #6739: GEODE-9484: added key - seqNumber logic

[GitBox <gi...@apache.org>]

mivanac commented on a change in pull request #6739:
URL: https://github.com/apache/geode/pull/6739#discussion_r694102402



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/event/DistributedEventTracker.java
##########
@@ -370,6 +383,17 @@ public boolean hasSeenEvent(EventID eventID, InternalCacheEvent tagHolder) {
       if (evh.isRemoved() || evh.getLastSequenceNumber() < eventID.getSequenceID()) {
         return false;
       }
+
+      if (tagHolder instanceof EntryEventImpl && evh.getKeySequenceIdSize() > 0) {

Review comment:
       This is new logic. If we are here, and getKeySequenceIdSize is zero, that would mean that EventSequenceNumberHolder is created with key=null. In that case old behavior is applied.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org