You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/04/25 07:45:19 UTC
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19800
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/19800/1
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19800/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/19800/3/be/src/service/impala-server.cc@2350
PS3, Line 2350: GetBuildVersion(
> GetBuildVersion() might be better since we don't need the "impalad build" p
Done
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 01:54:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 9
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 27 May 2023 07:53:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13136/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 May 2023 16:32:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 04:19:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
LGTM. Just have a minor suggestion.
http://gerrit.cloudera.org:8080/#/c/19800/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/19800/3/be/src/service/impala-server.cc@2350
PS3, Line 2350: GetVersionString
GetBuildVersion() might be better since we don't need the "impalad build" prefix.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 19 May 2023 08:35:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9357/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 9
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 27 May 2023 02:28:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 06:26:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12859/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 08:06:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto
File common/protobuf/statestore_service.proto:
http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto@80
PS2, Line 80: optional string process_start_time = 13;
nit: please add comments as we did for other fields. Also mention this is a pretty-printed string.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 15 May 2023 00:05:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13117/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 02:15:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13118/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 03:00:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 9
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 27 May 2023 02:28:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19800
to look at the new patch set (#4).
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.py
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/19800/4
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19800/4/common/protobuf/statestore_service.proto
File common/protobuf/statestore_service.proto:
http://gerrit.cloudera.org:8080/#/c/19800/4/common/protobuf/statestore_service.proto@79
PS4, Line 79:
Why remove the comments for two new variables?
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 02:32:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9356/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 May 2023 16:11:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19800
to look at the new patch set (#3).
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 33 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/19800/3
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19800
to look at the new patch set (#5).
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.py
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 33 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/19800/5
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto
File common/protobuf/statestore_service.proto:
http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto@80
PS2, Line 80: // The process start time of this backend, represented as a date-time string in the
> nit: please add comments as we did for other fields. Also mention this is a
Done
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 15 May 2023 02:42:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9355/
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 May 2023 13:21:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19800
to look at the new patch set (#8).
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.py
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 37 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/19800/8
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 May 2023 21:36:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9350/
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 11:45:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19800/4/common/protobuf/statestore_service.proto
File common/protobuf/statestore_service.proto:
http://gerrit.cloudera.org:8080/#/c/19800/4/common/protobuf/statestore_service.proto@79
PS4, Line 79:
> Why remove the comments for two new variables?
Sorry, I think they were overwritten by an older version.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 02:43:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9350/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 06:26:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13038/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 15 May 2023 03:02:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9355/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 May 2023 07:59:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 3: Code-Review+1
Except Quanlong's comments, others look good to me.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 24 May 2023 17:41:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 5: Code-Review+2
Carry Wenzhe's +1.
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 25 May 2023 06:25:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
IMPALA-12096: Add process start time and version to backends webui
This patch adds process start time and version to the /backends page.
Two more optional elements are added in BackendDescriptorPB and can
be broadcast through statestore topic. This information should be
helpful for users checking all backends in a large cluster.
For display, as two more columns are added to the table of backend
information, the table is changed to 'table-responsive' to be scrolled
horizontally with ease. A sample screenshot is attached to the
IMPALA-12096 ticket.
Testing:
- Added cases to test_web_pages.py
Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Reviewed-on: http://gerrit.cloudera.org:8080/19800
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M common/protobuf/statestore_service.proto
M tests/webserver/test_web_pages.py
M www/backends.tmpl
5 files changed, 37 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 10
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )
Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 27 May 2023 02:27:10 +0000
Gerrit-HasComments: No