You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/03/01 05:06:18 UTC

Re: [PR] [SPARK-47202][PYTHON][TESTS][FOLLOW-UP] Test timestamp with tzinfo in toPandas and createDataFrame with Arrow optimized [spark]

dongjoon-hyun commented on code in PR #45308:
URL: https://github.com/apache/spark/pull/45308#discussion_r1508489096


##########
python/pyspark/sql/tests/test_arrow.py:
##########
@@ -18,10 +18,12 @@
 import datetime
 import os
 import threading
+import calendar
 import time
 import unittest
 from typing import cast
 from collections import namedtuple
+from zoneinfo import ZoneInfo

Review Comment:
   Oh, `branch-3.5` PyPy 3.8 seems to complain.
   - https://github.com/apache/spark/actions/runs/8077039915/job/22066597081
   ```
   Traceback (most recent call last):
     File "/usr/local/pypy/pypy3.8/lib/pypy3.8/runpy.py", line 197, in _run_module_as_main
       return _run_code(code, main_globals, None,
     File "/usr/local/pypy/pypy3.8/lib/pypy3.8/runpy.py", line 87, in _run_code
       exec(code, run_globals)
     File "/__w/spark/spark/python/pyspark/sql/tests/test_arrow.py", line 28, in <module>
       from zoneinfo import ZoneInfo
   ModuleNotFoundError: No module named 'zoneinfo'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org