You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by anuruddhal <gi...@git.apache.org> on 2015/04/27 06:33:55 UTC

[GitHub] stratos pull request: Refactoring REST API

GitHub user anuruddhal opened a pull request:

    https://github.com/apache/stratos/pull/288

    Refactoring REST API

    Following Changes were done.
    
    Catch specific/custom exception - customize the log messages according to exception type (addCartridge(), updateCartridge() etc.)
    
    getAvailableCartridges() - remove obsolete code & simplify
    
    Remove obsolete code related to billing
    
    getCartridgesByFilter() remove hard-coded strings
    
    Change method parameters to primitive boolean
    
    Refactor isAlreadySubscribed() method
    
    Add missing method comments
    
    Refactor validateDeploymentPolicy(), getApplicationRuntime(), getApplicationSignUps()
    
    Make private static log to be final
    
    Rename StratosUserManager as a util class and make the methods static

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anuruddhal/stratos master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #288
    
----
commit f251849a99d8571f0b252a1f42c7cc4231ec0a7b
Author: anuruddhal <an...@gmail.com>
Date:   2015-04-22T06:20:50Z

    Moving non-API methods to StratosApiV41Utils class from StratosApiV41 class

commit 27c530b3627ad3e9cf1ca4ea5af4c188f9f79210
Author: anuruddhal <an...@gmail.com>
Date:   2015-04-22T12:12:11Z

    Merge remote-tracking branch 'upstream/master'

commit f0c4725a94eea774ee86770e9d56519046d79073
Author: anuruddhal <an...@gmail.com>
Date:   2015-04-24T04:10:17Z

    Merge remote-tracking branch 'upstream/master'

commit 73fce5f33eef8e70391f9392335b8a958f5dddfc
Author: anuruddhal <an...@gmail.com>
Date:   2015-04-27T04:26:11Z

    Refactoring Rest API

commit a996841d0586f637f29bc42f45360befb9f63ecf
Author: anuruddhal <an...@gmail.com>
Date:   2015-04-27T04:28:43Z

    Refactoring Rest API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Refactoring REST API

Posted by anuruddhal <gi...@git.apache.org>.
Github user anuruddhal closed the pull request at:

    https://github.com/apache/stratos/pull/288


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Refactoring REST API

Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:

    https://github.com/apache/stratos/pull/288#issuecomment-97428588
  
    Thanks @anuruddhal for the fixes, as I can see there are merge conflicts in this pull request now. Would you mind resolving them?
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---