You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/02 03:04:37 UTC

[GitHub] [arrow] andygrove commented on a change in pull request #8313: ARROW-4927: [Rust] Update top level README to describe current functionality

andygrove commented on a change in pull request #8313:
URL: https://github.com/apache/arrow/pull/8313#discussion_r498601108



##########
File path: rust/README.md
##########
@@ -51,11 +72,11 @@ This populates data in two git submodules:
 Create two new environment variables to point to these directories as follows:
 
 ```bash
-export PARQUET_TEST_DATA=/path/to/arrow/cpp/submodules/parquet-testing/data
-export ARROW_TEST_DATA=/path/to/arrow/testing/data/
+export PARQUET_TEST_DATA=../../cpp/submodules/parquet-testing/data

Review comment:
       Relative paths potentially won't work when running `cargo test` from within the crate directories themselves rather than from the workspace directory. Perhaps we could do this instead?
   
   ```
   export PARQUET_TEST_DATA=`pwd`/../../cpp/submodules/parquet-testing/data
   export ARROW_TEST_DATA=`pwd`/../../testing/data/
   ```
   
   I'm assuming this works both on Mac and Linux, at least.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org