[GitHub] yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r226366888
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
 ##########
 @@ -108,9 +111,11 @@
 
 	private volatile boolean stopped;
 
-	public AkkaRpcService(final ActorSystem actorSystem, final Time timeout) {
+	public AkkaRpcService(final ActorSystem actorSystem, final Configuration configuration) {
 
 Review comment:
   Sorry, I forgot to refactor this code segment : 
   
   ```
   if (actorSystem.settings().config().hasPath(MAXIMUM_FRAME_SIZE_PATH)) {
   			maximumFramesize = actorSystem.settings().config().getBytes(MAXIMUM_FRAME_SIZE_PATH);
   		} else {
   			// only local communication
   			maximumFramesize = Long.MAX_VALUE;
   		}
   ```
   
   to use
   
   ```
   configuration.getString(AkkaOptions.FRAMESIZE);
   ```
   
   (this suggestion from @zentol)
   
   If I would do this, I think it's better to replace scattered config items into one Configuration object so that we can encapsulate change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services