You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2026/04/02 22:18:52 UTC

[PR] [SPARK-56345][PYTHON][TESTS] Use `pd.Series.__name__` in Arrow UDF type-hint test [spark]

ueshin opened a new pull request, #55175:
URL: https://github.com/apache/spark/pull/55175

   ### What changes were proposed in this pull request?
   
   This PR updates `python/pyspark/sql/tests/arrow/test_arrow_udf_typehints.py` to make the negative Arrow UDF type-hint assertion build the expected error pattern from `pd.Series.__name__` instead of hard-coding `pandas.core.series.Series`.
   
   The change is limited to the test expectation in `ArrowUDFTypeHintsTests.test_negative_with_pandas_udf`.
   
   ### Why are the changes needed?
   
   The previous assertion depended on a hard-coded fully qualified pandas type name. Building the expected pattern from `pd.Series.__name__` makes the test less coupled to a specific pandas type string representation while still checking that an unsupported pandas `Series` signature is rejected.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Updated the related test expectation.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56345][PYTHON][TESTS] Use `pd.Series.__name__` in Arrow UDF type-hint test [spark]

Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #55175:
URL: https://github.com/apache/spark/pull/55175#issuecomment-4180785845

   cc @gaogaotiantian @HyukjinKwon @zhengruifeng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56345][PYTHON][TESTS] Use `pd.Series.__name__` in Arrow UDF type-hint test [spark]

Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin closed pull request #55175: [SPARK-56345][PYTHON][TESTS] Use `pd.Series.__name__` in Arrow UDF type-hint test
URL: https://github.com/apache/spark/pull/55175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56345][PYTHON][TESTS] Use `pd.Series.__name__` in Arrow UDF type-hint test [spark]

Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #55175:
URL: https://github.com/apache/spark/pull/55175#issuecomment-4181162959

   Thanks! merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org