You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/19 02:42:50 UTC
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/
-----------------------------------------------------------
(Updated June 19, 2015, 12:42 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
Summary (updated)
-----------------
Sent StatusUpdates if checkpointed resources don't exist on the slave.
Repository: mesos
Description
-------
No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
Diffs
-----
src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
Diff: https://reviews.apache.org/r/35433/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88513
-----------------------------------------------------------
Ship it!
Want to link the RR with MESOS-2491 for posterity?
src/slave/slave.cpp (line 1399)
<https://reviews.apache.org/r/35433/#comment141093>
I believe you've chosen `TASK_LOST` because the appropriate `CheckpointResourcesMessage` is about to arrive and restarting the task may succeed. If this is the case, let's expand the comment.
src/slave/slave.cpp (lines 1409 - 1416)
<https://reviews.apache.org/r/35433/#comment141095>
Let's add `TaskStatus::Reason` for that! How about `REASON_RESOURCES_UNKNOWN`? I'm ok with doing it in a separate RR in order not to block this patch.
src/slave/slave.cpp (lines 1420 - 1422)
<https://reviews.apache.org/r/35433/#comment141094>
I've seen your discussion about these lines and that you plan to follow-up on this. In the meantime, mind throwing a comment, why do we need to remove the framework here? (I believe it is because we could have created it one step before in `runTask()`, right?)
src/slave/slave.cpp (line 1446)
<https://reviews.apache.org/r/35433/#comment141096>
Ditto.
- Alexander Rukletsov
On June 19, 2015, 12:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 12:42 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35433/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Michael Park <mc...@gmail.com>.
> On June 19, 2015, 10:57 p.m., Jie Yu wrote:
> > src/slave/slave.cpp, lines 1579-1583
> > <https://reviews.apache.org/r/35433/diff/9/?file=988310#file988310line1579>
> >
> > This should be a CHECK instead?
I've created [r35686](https://reviews.apache.org/r/35686/) as a follow-up for this.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88595
-----------------------------------------------------------
On June 19, 2015, 2:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-2491
> https://issues.apache.org/jira/browse/MESOS-2491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35433/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88595
-----------------------------------------------------------
src/slave/slave.cpp (lines 1579 - 1583)
<https://reviews.apache.org/r/35433/#comment141187>
This should be a CHECK instead?
- Jie Yu
On June 19, 2015, 2:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-2491
> https://issues.apache.org/jira/browse/MESOS-2491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35433/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88541
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On June 19, 2015, 2:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-2491
> https://issues.apache.org/jira/browse/MESOS-2491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35433/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88568
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 2:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-2491
> https://issues.apache.org/jira/browse/MESOS-2491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35433/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/
-----------------------------------------------------------
(Updated June 19, 2015, 2:31 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
Changes
-------
Added `TaskStatus::REASON_RESOURCES_UNKNOWN`
Added comments around why we need:
```cpp
if (framework->executors.empty() && framework->pending.empty()) {
removeFramework(framework);
}
```
before we exit `_runTask`.
Bugs: MESOS-2491
https://issues.apache.org/jira/browse/MESOS-2491
Repository: mesos
Description
-------
No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
Diffs (updated)
-----
include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
Diff: https://reviews.apache.org/r/35433/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35433: Sent StatusUpdates if checkpointed
resources don't exist on the slave.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/
-----------------------------------------------------------
(Updated June 19, 2015, 12:29 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
Changes
-------
Link [MESOS-2491](https://issues.apache.org/jira/browse/MESOS-2491)
Bugs: MESOS-2491
https://issues.apache.org/jira/browse/MESOS-2491
Repository: mesos
Description
-------
No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
Diffs
-----
src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
Diff: https://reviews.apache.org/r/35433/diff/
Testing
-------
`make check`
Thanks,
Michael Park