[GitHub] [lucene] dsmiley commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #412:
URL: https://github.com/apache/lucene/pull/412#issuecomment-990226022


   Let's definitely *not* double up the tests in the name of test coverage.  It's not worth the maintenance overhead.  As it is, I think there's some other double-up test for something that didn't get reverted.  The deprecated methods (there for mutability) can be un-tested.  We can use the builder everywhere henceforth.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org