You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by GitBox <gi...@apache.org> on 2020/04/23 21:45:31 UTC
[GitHub] [uima-uimaj] reckart opened a new pull request #38: Sync master v2 to master
reckart opened a new pull request #38:
URL: https://github.com/apache/uima-uimaj/pull/38
* [UIMA-6200] Constructing aggregate engines is slow
* [UIMA-6187] add eol=lf for .sh files
* [UIMA-6128] hook up xcas-1-1 to save
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [uima-uimaj] reckart opened a new pull request #38: Sync
master v2 to master
Posted by Richard Eckart de Castilho <re...@apache.org>.
On 25. Apr 2020, at 23:15, Marshall Schor <ms...@schor.com> wrote:
>
> no, you are correct, I am mistaken (about the license). A (hopefully) temporary
> confusion :-).
>
> At some point, it might make sense to converge on just a single xmlunit provider.
So as far as I can see, we do not use org.xmlunit so far in UIMA (core / uimaFIT).
It appears to me that org.xmlunit is the groupId used by v2 of xmlunit while v1
was using the groupId xmlunit. So it is more or less the same library at different
stages of development.
I have created an issue for the upgrade: https://issues.apache.org/jira/browse/UIMA-6227
Cheers,
-- Richard
Re: [GitHub] [uima-uimaj] reckart opened a new pull request #38: Sync
master v2 to master
Posted by Marshall Schor <ms...@schor.com>.
no, you are correct, I am mistaken (about the license). A (hopefully) temporary
confusion :-).
At some point, it might make sense to converge on just a single xmlunit provider.
-Marshall
On 4/25/2020 3:19 PM, Richard Eckart de Castilho wrote:
> On 25. Apr 2020, at 21:16, Marshall Schor <ms...@schor.com> wrote:
>> It looks like it has a license (a BSD form) which I think might require updating
>> all the licenses / (maybe notices) for both source and binary distr.
> In the source distribution, AFAIK we do not (have to) mention the licenses of dependencies.
>
> Since it is a build dependency that is not (should not be) included in the binary distribution, it also shouldn't be necessary to include it there.
>
> Am I mistaken?
>
> Cheers,
>
> -- Richard
Re: [GitHub] [uima-uimaj] reckart opened a new pull request #38: Sync
master v2 to master
Posted by Richard Eckart de Castilho <re...@apache.org>.
On 25. Apr 2020, at 21:16, Marshall Schor <ms...@schor.com> wrote:
>
> It looks like it has a license (a BSD form) which I think might require updating
> all the licenses / (maybe notices) for both source and binary distr.
In the source distribution, AFAIK we do not (have to) mention the licenses of dependencies.
Since it is a build dependency that is not (should not be) included in the binary distribution, it also shouldn't be necessary to include it there.
Am I mistaken?
Cheers,
-- Richard
Re: [GitHub] [uima-uimaj] reckart opened a new pull request #38: Sync
master v2 to master
Posted by Marshall Schor <ms...@schor.com>.
While reviewing the changes, I see "xmlunit" dependency was added to
uimaj-parent pom.
This is used to compare xml outputs, I believe.
It looks like it has a license (a BSD form) which I think might require updating
all the licenses / (maybe notices) for both source and binary distr.
There are other xmlunit implementations that are under the apache 2.0 license,
e.g. search maven for org.xmlunit:... (instead of xmlunit:xmlunit).
Some of the xml comparison code uses that version.
I think some uses of the xmluint:xmlunit might have leaked into other modules,
so a review might be needed, to convert these.
-Marshall
==============
Other unit tests use some xml compare routine - could that one be used instead?
-Marshall
On 4/23/2020 5:45 PM, GitBox wrote:
> reckart opened a new pull request #38:
> URL: https://github.com/apache/uima-uimaj/pull/38
>
>
> * [UIMA-6200] Constructing aggregate engines is slow
> * [UIMA-6187] add eol=lf for .sh files
> * [UIMA-6128] hook up xcas-1-1 to save
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>