[GitHub] [calcite] zoudan commented on a diff in pull request #3162: CALCITE-5659/ Allow CAST in an INTERVAL literal

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3162:
URL: https://github.com/apache/calcite/pull/3162#discussion_r1174542816


##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -5223,6 +5223,8 @@ private static Matcher<SqlNode> isCharLiteral(String s) {
         .ok("INTERVAL '1:2:3' HOUR TO SECOND");
     f.sql("interval \"1:2:3\" hour to second")
         .ok("INTERVAL '1:2:3' HOUR TO SECOND");
+    f.sql("interval cast(1 as INT64) year")

Review Comment:
   Shall we add more test to ensure the calculation results are within expectations, not only the parse stage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org