You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/06/09 12:21:33 UTC
[commons-email] branch master updated: Use diamonds and StringBuilder.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git
The following commit(s) were added to refs/heads/master by this push:
new 45a2669 Use diamonds and StringBuilder.
45a2669 is described below
commit 45a2669f3360e6313849c3203941caa6c7542c19
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jun 9 08:21:19 2022 -0400
Use diamonds and StringBuilder.
---
src/main/java/org/apache/commons/mail/Email.java | 2 +-
src/main/java/org/apache/commons/mail/EmailUtils.java | 2 +-
src/main/java/org/apache/commons/mail/HtmlEmail.java | 2 +-
src/main/java/org/apache/commons/mail/util/MimeMessageParser.java | 6 +++---
src/test/java/org/apache/commons/mail/AbstractEmailTest.java | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/main/java/org/apache/commons/mail/Email.java b/src/main/java/org/apache/commons/mail/Email.java
index 16a8ac2..ece572b 100644
--- a/src/main/java/org/apache/commons/mail/Email.java
+++ b/src/main/java/org/apache/commons/mail/Email.java
@@ -454,7 +454,7 @@ public abstract class Email
// whose content-type is some form of text.
if (this.contentType.startsWith("text/") && EmailUtils.isNotEmpty(this.charset))
{
- final StringBuffer contentTypeBuf = new StringBuffer(this.contentType);
+ final StringBuilder contentTypeBuf = new StringBuilder(this.contentType);
contentTypeBuf.append(strMarker);
contentTypeBuf.append(this.charset);
this.contentType = contentTypeBuf.toString();
diff --git a/src/main/java/org/apache/commons/mail/EmailUtils.java b/src/main/java/org/apache/commons/mail/EmailUtils.java
index 7df8c42..e3de9f8 100644
--- a/src/main/java/org/apache/commons/mail/EmailUtils.java
+++ b/src/main/java/org/apache/commons/mail/EmailUtils.java
@@ -238,7 +238,7 @@ final class EmailUtils
}
}
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
final int gap = end - start;
while (count-- != 0)
diff --git a/src/main/java/org/apache/commons/mail/HtmlEmail.java b/src/main/java/org/apache/commons/mail/HtmlEmail.java
index 864e6ff..4a7ca94 100644
--- a/src/main/java/org/apache/commons/mail/HtmlEmail.java
+++ b/src/main/java/org/apache/commons/mail/HtmlEmail.java
@@ -179,7 +179,7 @@ public class HtmlEmail extends MultiPartEmail
setTextMsg(msg);
- final StringBuffer htmlMsgBuf = new StringBuffer(
+ final StringBuilder htmlMsgBuf = new StringBuilder(
msg.length()
+ HTML_MESSAGE_START.length()
+ HTML_MESSAGE_END.length()
diff --git a/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java b/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
index 915c834..2fa22b5 100644
--- a/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
+++ b/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
@@ -103,7 +103,7 @@ public class MimeMessageParser
public List<javax.mail.Address> getTo() throws Exception
{
final javax.mail.Address[] recipients = this.mimeMessage.getRecipients(Message.RecipientType.TO);
- return recipients != null ? Arrays.asList(recipients) : new ArrayList<javax.mail.Address>();
+ return recipients != null ? Arrays.asList(recipients) : new ArrayList<>();
}
/**
@@ -113,7 +113,7 @@ public class MimeMessageParser
public List<javax.mail.Address> getCc() throws Exception
{
final javax.mail.Address[] recipients = this.mimeMessage.getRecipients(Message.RecipientType.CC);
- return recipients != null ? Arrays.asList(recipients) : new ArrayList<javax.mail.Address>();
+ return recipients != null ? Arrays.asList(recipients) : new ArrayList<>();
}
/**
@@ -123,7 +123,7 @@ public class MimeMessageParser
public List<javax.mail.Address> getBcc() throws Exception
{
final javax.mail.Address[] recipients = this.mimeMessage.getRecipients(Message.RecipientType.BCC);
- return recipients != null ? Arrays.asList(recipients) : new ArrayList<javax.mail.Address>();
+ return recipients != null ? Arrays.asList(recipients) : new ArrayList<>();
}
/**
diff --git a/src/test/java/org/apache/commons/mail/AbstractEmailTest.java b/src/test/java/org/apache/commons/mail/AbstractEmailTest.java
index 8c1324f..34cc931 100644
--- a/src/test/java/org/apache/commons/mail/AbstractEmailTest.java
+++ b/src/test/java/org/apache/commons/mail/AbstractEmailTest.java
@@ -417,7 +417,7 @@ public abstract class AbstractEmailTest
return "";
}
- final StringBuffer serializedEmail = new StringBuffer();
+ final StringBuilder serializedEmail = new StringBuilder();
final MimeMessage message = wiserMessage.getMimeMessage();
// Serialize the headers