You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2023/12/19 10:55:23 UTC
[PR] [MINOR][SQL] Rename ioschema to ioSchema [spark]
huangxiaopingRD opened a new pull request, #44414:
URL: https://github.com/apache/spark/pull/44414
### What changes were proposed in this pull request?
Rename ioschema to ioSchema
### Why are the changes needed?
improve Spark code
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename ioschema to ioSchema [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44414: [MINOR][SQL] Rename ioschema to ioSchema
URL: https://github.com/apache/spark/pull/44414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename ioschema to ioSchema [spark]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #44414:
URL: https://github.com/apache/spark/pull/44414#discussion_r1432175599
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/ScriptTransformation.scala:
##########
@@ -25,13 +25,13 @@ import org.apache.spark.sql.catalyst.plans.ReferenceAllColumns
*
* @param script the command that should be executed.
* @param output the attributes that are produced by the script.
- * @param ioschema the input and output schema applied in the execution of the script.
+ * @param ioSchema the input and output schema applied in the execution of the script.
Review Comment:
You are right, I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename ioschema to ioSchema [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44414:
URL: https://github.com/apache/spark/pull/44414#discussion_r1432048197
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/ScriptTransformation.scala:
##########
@@ -25,13 +25,13 @@ import org.apache.spark.sql.catalyst.plans.ReferenceAllColumns
*
* @param script the command that should be executed.
* @param output the attributes that are produced by the script.
- * @param ioschema the input and output schema applied in the execution of the script.
+ * @param ioSchema the input and output schema applied in the execution of the script.
Review Comment:
Let's avoid this kind of renaming that is virtually noop but just makes the conflicts when you backport other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org