You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/06 15:59:36 UTC
[GitHub] [camel] javaduke opened a new pull request #6671: ManagedDebugger exposes Message History
javaduke opened a new pull request #6671:
URL: https://github.com/apache/camel/pull/6671
This PR resolves the https://issues.apache.org/jira/browse/CAMEL-17444
The message history is exposed as a List of Maps containing String pairs, so that the tooling can use it in debugging and displaying stack traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] javaduke commented on pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
javaduke commented on pull request #6671:
URL: https://github.com/apache/camel/pull/6671#issuecomment-1006781608
OK, no problem I can rewrite it to return XML, give me a few min :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6671:
URL: https://github.com/apache/camel/pull/6671#discussion_r779777153
##########
File path: core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
##########
@@ -172,4 +172,7 @@
@ManagedOperation(description = "Updates/adds the exchange property (with a new type) on the suspended breakpoint at the given node id")
void setExchangePropertyOnBreakpoint(String nodeId, String exchangePropertyName, Object value, String type);
+
+ @ManagedOperation(description = "Returns the message history at the given node id as XML")
+ String getMessageHistory(String nodeId);
Review comment:
Can we rename this to
messageHistorayOnBreakpointAsXml
because we made a mistake a long time ago that a JMX operation should not be named getter/setter - there are some tools/jconsole etc that dont work well with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] javaduke commented on a change in pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
javaduke commented on a change in pull request #6671:
URL: https://github.com/apache/camel/pull/6671#discussion_r779779228
##########
File path: core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
##########
@@ -172,4 +172,7 @@
@ManagedOperation(description = "Updates/adds the exchange property (with a new type) on the suspended breakpoint at the given node id")
void setExchangePropertyOnBreakpoint(String nodeId, String exchangePropertyName, Object value, String type);
+
+ @ManagedOperation(description = "Returns the message history at the given node id as XML")
+ String getMessageHistory(String nodeId);
Review comment:
Yes, makes perfect sense. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6671:
URL: https://github.com/apache/camel/pull/6671#issuecomment-1006763360
In a pure JMX world such sheet data would be represented as a javax.management.openmbean.TabularData instead. We do this in some other MBeans in Camel.
However I not sure sure how well you can invoke that from the IDEA Camel plugin.
If not a tabular data, then I think its better to make this like the others as a XML - then its similar to the other opreations.
We have to consider that this is not only for IDEA but for other tools that comes - and also we should make it similar to the "Camel standard" we have today.
Yeah XML is "old school" but it works for everyone ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] javaduke commented on pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
javaduke commented on pull request #6671:
URL: https://github.com/apache/camel/pull/6671#issuecomment-1006799000
@davsclaus Done, history is now an XML, I can easily parse it in the debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6671: ManagedDebugger exposes Message History
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6671:
URL: https://github.com/apache/camel/pull/6671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org