You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ta...@apache.org on 2021/02/19 05:47:56 UTC
[hadoop] branch branch-3.3 updated: HDFS-15835. Erasure coding:
Add/remove logs for the better readability/debugging. Contributed by Bhavik
Patel.
This is an automated email from the ASF dual-hosted git repository.
tasanuma pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new 1125e3f HDFS-15835. Erasure coding: Add/remove logs for the better readability/debugging. Contributed by Bhavik Patel.
1125e3f is described below
commit 1125e3f0c055fa0964b2e352ec7caadeaea9a4f1
Author: Takanobu Asanuma <ta...@apache.org>
AuthorDate: Fri Feb 19 14:44:58 2021 +0900
HDFS-15835. Erasure coding: Add/remove logs for the better readability/debugging. Contributed by Bhavik Patel.
(cherry picked from commit 25af8901a978e1b5220a961813d0e0c834010553)
---
.../hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java | 5 +++--
.../java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java | 1 -
.../org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java | 5 +++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
index 73f5596..d5fdba8 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
@@ -343,6 +343,7 @@ public final class ErasureCodingPolicyManager {
policiesByName.values().toArray(new ErasureCodingPolicyInfo[0]);
allPersistedPolicies.put(policy.getId(),
new ErasureCodingPolicyInfo(policy));
+ LOG.info("Added erasure coding policy " + policy);
return policy;
}
@@ -414,7 +415,7 @@ public final class ErasureCodingPolicyManager {
enabledPolicies =
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
info.setState(ErasureCodingPolicyState.DISABLED);
- LOG.info("Disable the erasure coding policy " + name);
+ LOG.info("Disabled the erasure coding policy " + name);
allPersistedPolicies.put(info.getPolicy().getId(),
createPolicyInfo(info.getPolicy(),
ErasureCodingPolicyState.DISABLED));
@@ -448,7 +449,7 @@ public final class ErasureCodingPolicyManager {
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
allPersistedPolicies.put(ecPolicy.getId(),
createPolicyInfo(info.getPolicy(), ErasureCodingPolicyState.ENABLED));
- LOG.info("Enable the erasure coding policy " + name);
+ LOG.info("Enabled the erasure coding policy " + name);
return true;
}
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
index 7bffee9..afd1814 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
@@ -8077,7 +8077,6 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
checkOperation(OperationCategory.WRITE);
checkErasureCodingSupported(operationName);
boolean success = false;
- LOG.info("Disable the erasure coding policy " + ecPolicyName);
try {
writeLock();
try {
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
index 1e248ee..66b2bcc 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
@@ -2262,10 +2262,10 @@ public class NameNodeRpcServer implements NamenodeProtocols {
try {
if (ecPolicyName == null) {
ecPolicyName = defaultECPolicyName;
- LOG.trace("No policy name is specified, " +
+ LOG.debug("No policy name is specified, " +
"set the default policy name instead");
}
- LOG.trace("Set erasure coding policy " + ecPolicyName + " on " + src);
+ LOG.debug("Set erasure coding policy {} on {}", ecPolicyName, src);
namesystem.setErasureCodingPolicy(src, ecPolicyName, cacheEntry != null);
success = true;
} finally {
@@ -2516,6 +2516,7 @@ public class NameNodeRpcServer implements NamenodeProtocols {
}
boolean success = false;
try {
+ LOG.debug("Unset erasure coding policy on {}", src);
namesystem.unsetErasureCodingPolicy(src, cacheEntry != null);
success = true;
} finally {
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org