You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/02/08 02:16:32 UTC

[GitHub] [royale-asjs] mjesteve opened a new pull request #1077: New bead BadgeWithMouseClick

mjesteve opened a new pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077


   I have made the changes in separate commits in case the proposed examples do not adapt.
   
   Hiedra.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] mjesteve closed pull request #1077: New bead BadgeWithMouseClick

Posted by GitBox <gi...@apache.org>.
mjesteve closed pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira commented on pull request #1077: New bead BadgeWithMouseClick

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077#issuecomment-775092373


   Hi Maria Jose, 
   thanks for the contribution. About the bead commit, I see it completely right.
   About the examples, I see examples I see various things:
   - hardcoded styles. In this case the bead just add a click behavior. So don't understand the need of all the styles added to TDJ. Think that TDJ has already considerable weight, and we need to keep in diet as much as we can.
   - Also I see examples in Button and Combo pages and additional renderer. Although is very valuable, I think the example should be just add the bead to one of the Badges already in place in the footer to show how it works.
   
   I think is good to separate the commits to help the review, but for next PRs, can you separate "by functionality", I mean. One PR for the framework bead and other for the examples? In the current way, it helps review, but since the first is ok but the later not, I still can't merge it.
   
   Thanks again for sharing the code! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira commented on pull request #1077: New bead BadgeWithMouseClick

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077#issuecomment-775113904


   Hi,
   
   yes one PR for the bead, and another for adding the new bead to one of the existing badges in TDJ.
   That way we can merge valid units on the fly and since are different if one has something wrong, that will not affect the other(s).
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] mjesteve commented on pull request #1077: New bead BadgeWithMouseClick

Posted by GitBox <gi...@apache.org>.
mjesteve commented on pull request #1077:
URL: https://github.com/apache/royale-asjs/pull/1077#issuecomment-775106436


   Hi Carlos, let's see if I understand you well ...
   What I should have done is send a PR with the bead and another PR with the examples?
   
   I create a new PR only with the bead and in another separate PR the small example that you tell me in ButtonPlayGround (I don't understand if I should simply add the bead to one of the existing buttons or I can create a new one, under the last one)
   
   Sorry for the inconvenience.
   Hiedra.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org