[GitHub] [echarts] plainheart commented on a change in pull request #16318: using utility methods for value type checking

[GitBox <gi...@apache.org>]

plainheart commented on a change in pull request #16318:
URL: https://github.com/apache/echarts/pull/16318#discussion_r777924878



##########
File path: src/coord/cartesian/Grid.ts
##########
@@ -49,7 +49,8 @@ import OrdinalScale from '../../scale/Ordinal';
 import { isCartesian2DSeries, findAxisModels } from './cartesianAxisHelper';
 import { CategoryAxisBaseOption, NumericAxisBaseOptionCommon } from '../axisCommonTypes';
 import { AxisBaseModel } from '../AxisBaseModel';
-import { alignScaleTicks, isIntervalOrLogScale } from '../../scale/helper';
+import { isIntervalOrLogScale } from '../../scale/helper';
+import { alignScaleTicks } from "../axisAlignTicks";

Review comment:
       Unexpected double quotation mark.

##########
File path: src/coord/radar/Radar.ts
##########
@@ -28,8 +28,8 @@ import GlobalModel from '../../model/Global';
 import ExtensionAPI from '../../core/ExtensionAPI';
 import { ScaleDataValue } from '../../util/types';
 import { ParsedModelFinder } from '../../util/model';
-import { map, each } from 'zrender/src/core/util';
-import { alignScaleTicks } from '../../scale/helper';
+import { map, each, isString, isNumber } from 'zrender/src/core/util';
+import { alignScaleTicks } from "../axisAlignTicks";

Review comment:
       Unexpected double quotation mark.

##########
File path: src/scale/helper.ts
##########
@@ -17,24 +17,20 @@
 * under the License.
 */
 
-import { NumericAxisBaseOptionCommon } from '../coord/axisCommonTypes';
-import {getPrecisionSafe, getPrecision, round, nice, quantityExponent} from '../util/number';
+import {getPrecision, round, nice, quantityExponent} from '../util/number';
 import IntervalScale from './Interval';
-import { getScaleExtent } from '../coord/axisHelper';
-import { AxisBaseModel } from '../coord/AxisBaseModel';
 import LogScale from './Log';
 import Scale from './Scale';
-import { warn } from '../util/log';
 
-const mathLog = Math.log;
+export const mathLog = Math.log;
 

Review comment:
       I ever thought if it may be slightly better to move all the mathematic functions to a common helper. Any idea? If it's feasible, that'll be a huge job.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org