You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/09/01 19:44:06 UTC
Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
Diffs
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630
src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd
src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
Diff: https://reviews.apache.org/r/38011/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99105
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38011]
All tests passed.
- Mesos ReviewBot
On Sept. 15, 2015, 5:47 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
> src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
> src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Sept. 15, 2015, 11:58 p.m., Guangya Liu wrote:
> > src/common/protobuf_utils.hpp, line 115
> > <https://reviews.apache.org/r/38011/diff/3/?file=1074048#file1074048line115>
> >
> > This should also be removed.
Thanks for spotting this :)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99190
-----------------------------------------------------------
On Sept. 15, 2015, 10:47 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 10:47 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
> src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
> src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99190
-----------------------------------------------------------
src/common/protobuf_utils.hpp (line 115)
<https://reviews.apache.org/r/38011/#comment156101>
This should also be removed.
- Guangya Liu
On 九月 15, 2015, 5:47 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated 九月 15, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
> src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
> src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99579
-----------------------------------------------------------
Ship it!
Fixed inline.
src/tests/master_maintenance_tests.cpp (line 100)
<https://reviews.apache.org/r/38011/#comment156511>
new line
src/tests/registrar_tests.cpp (lines 535 - 536)
<https://reviews.apache.org/r/38011/#comment156513>
Fits on 1 line.
src/tests/registrar_tests.cpp (lines 624 - 625)
<https://reviews.apache.org/r/38011/#comment156512>
Fits on 1 line.
- Joris Van Remoortere
On Sept. 16, 2015, 7:38 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 7:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
> src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
> src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99292
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38011]
All tests passed.
- Mesos ReviewBot
On Sept. 16, 2015, 7:38 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 7:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
> src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
> src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 12:38 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
Changes
-------
Remove stale todo.
Repository: mesos
Description
-------
This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
Diff: https://reviews.apache.org/r/38011/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 10:47 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
Changes
-------
Missed a few lines in the previous diff.
Repository: mesos
Description
-------
This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
Diff: https://reviews.apache.org/r/38011/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 10:21 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
Changes
-------
Rebase on the finalized (committed) version of parse<Repeated...> and the (committed) maintenance primitives code from Joris.
Repository: mesos
Description
-------
This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da
src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e
src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c
src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71
src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
Diff: https://reviews.apache.org/r/38011/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 38011: Maintenance Primitives: Use the
parse> helper instead of a plural MachineID protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review97328
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37826, 37827, 37830, 38011]
All tests passed.
- Mesos ReviewBot
On Sept. 1, 2015, 5:44 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:44 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the MachineIDs protobuf and changes it to instead use the RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and /machine/down, which both take an array instead of an object now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630
> src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0
> src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd
> src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955
>
> Diff: https://reviews.apache.org/r/38011/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>