[GitHub] [spark] amaliujia commented on a diff in pull request #38244: [SPARK-39375][CONNECT][FOLLOWUP] Sync python generated proto files

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38244:
URL: https://github.com/apache/spark/pull/38244#discussion_r995233424


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -319,9 +319,9 @@ def __init__(
 
     def _convert_measure(
         self, m: MeasureType, session: Optional["RemoteSparkSession"]
-    ) -> proto.Aggregate.Measure:
+    ) -> proto.Aggregate.AggregateFunction:
         exp, fun = m
-        measure = proto.Aggregate.Measure()
+        measure = proto.Aggregate.AggregateFunction()

Review Comment:
   This is the only code change that is caused by the proto change. We are lacking of aggregate testing coverage thus there is no tests affected. I will follow up on the testing coverage but that is a different problem.
   
   cc @zhengruifeng 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org