You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/06/05 13:05:27 UTC
[GitHub] [celix] rbulter opened a new pull request #250: refactor read and write function
rbulter opened a new pull request #250:
URL: https://github.com/apache/celix/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #250: refactor read and write function
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `63.84%`.
[](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 67.82% 67.85% +0.02%
==========================================
Files 127 127
Lines 26375 26384 +9
==========================================
+ Hits 17890 17903 +13
+ Misses 8485 8481 -4
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.17% <63.41%> (-1.03%)` | :arrow_down: |
| [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: |
| [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: |
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.52% <0.00%> (+0.21%)` | :arrow_up: |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.23% <0.00%> (+1.15%)` | :arrow_up: |
| [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <0.00%> (+10.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=footer). Last update [f25f19f...9cdf93b](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes merged pull request #250: refactor read and write function from TcpAdmin to handle Send Timeout expire
Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #250:
URL: https://github.com/apache/celix/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter edited a comment on pull request #250: refactor read and write function
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `63.84%`.
[](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 67.82% 67.86% +0.03%
==========================================
Files 127 127
Lines 26375 26384 +9
==========================================
+ Hits 17890 17906 +16
+ Misses 8485 8478 -7
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.17% <63.41%> (-1.03%)` | :arrow_down: |
| [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: |
| [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: |
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.52% <0.00%> (+0.21%)` | :arrow_up: |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `95.10% <0.00%> (+2.01%)` | :arrow_up: |
| [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <0.00%> (+10.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=footer). Last update [f25f19f...9cdf93b](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter edited a comment on pull request #250: refactor read and write function from TcpAdmin to handle Send Timeout expire
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `63.84%`.
[](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 67.82% 67.80% -0.03%
==========================================
Files 127 127
Lines 26375 26384 +9
==========================================
Hits 17890 17890
- Misses 8485 8494 +9
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.17% <63.41%> (-1.03%)` | :arrow_down: |
| [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: |
| [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: |
| [libs/framework/src/service\_tracker.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL3NlcnZpY2VfdHJhY2tlci5j) | `77.13% <0.00%> (-0.19%)` | :arrow_down: |
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.44% <0.00%> (+0.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=footer). Last update [f25f19f...6d3172f](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org