You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by "Andrew Black (JIRA)" <ji...@apache.org> on 2006/01/12 17:04:22 UTC
[jira] Created: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
[Mac OS X 10.2.8] Missing header guards in utility source files
---------------------------------------------------------------
Key: STDCXX-117
URL: http://issues.apache.org/jira/browse/STDCXX-117
Project: STDCXX
Type: Bug
Components: Utilities
Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
Reporter: Andrew Black
Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526578 ]
Martin Sebor commented on STDCXX-117:
-------------------------------------
Andrew, what's the status of this?
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Fix For: 4.2
>
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor updated STDCXX-117:
--------------------------------
Affects Version/s: 4.2
Scheduled for 4.2.0.
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 4.2
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Andrew Black (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/STDCXX-117?page=all ]
Andrew Black updated STDCXX-117:
--------------------------------
Attachment: utilguard.diff
And the (straightforward) patch to util/locale.cpp, util/charmap.cpp, util/charmap.h, and util/aliases.cpp
Log entry as follows?
STDCXX-117
* aliases.cpp [_RWSTD_NO_NL_LANGINFO] (<langinfo.h>): Guarded against inclusion when the header is detected to be missing at configuration time.
* charmap.cpp [_RWSTD_NO_ICONV] (<iconv.h>): Guarded against inclusion when the header is detected to be missing at configuration time.
* charmap.h [_RWSTD_NO_ICONV] (<iconv.h>): Guarded against inclusion when the header is detected to be missing at configuration time.
* locale.cpp [_RWSTD_NO_ICONV] (<iconv.h>): Guarded against inclusion when the header is detected to be missing at configuration time.
* locale.cpp [_RWSTD_NO_NL_LANGINFO] (<langinfo.h>): Guarded against inclusion when the header is detected to be missing at configuration time.
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: http://issues.apache.org/jira/browse/STDCXX-117
> Project: STDCXX
> Type: Bug
> Components: Utilities
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Attachments: utilguard.diff
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Andrew Black (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500409 ]
Andrew Black commented on STDCXX-117:
-------------------------------------
Per recent comments in other issues, I no longer have this operating system installed on a machine, so it is difficult to retest on the operating system this was reported for.
Nightly testing indicates that the patch was a partial fix for FreeBSD. The errors about the missing headers are no longer present, but the errors about the iconv_t data type not being found are still present.
I believe I have a solution for the rest of the errors, but I will need to test it before checking it in.
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Fix For: 4.2
>
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Andrew Black (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Black resolved STDCXX-117.
---------------------------------
Resolution: Fixed
It looks like the change to fix STDCXX-404 also resolved this issue. I've started a manual build with the latest svn trunk, and the locale/localedef utility appears to run correctly, excluding some of the more exotic character encodings- EUC-JP, Shift_JIS, and EUC-KR which appear to crash after stage one of the locale tests.
I'm not certain what happened with the patch I'd started to create for this issue. Odds are it's probably living on my old computer. However, memory is saying that it was similar to the change which was committed for STDCXX-404. I believe what happened was I was uncertain on what the logic flow should be to handle the character conversions when neither iconv nor the windows functions were available. As a result progress was halted, though I neglected to update the status of this ticket to reflect this halt.
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Fix For: 4.2
>
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor reassigned STDCXX-117:
-----------------------------------
Assignee: Andrew Black
Whoops, I completely spaced this patch! It looks good and I think it's needed even for FreeBSD (see STDCXX-404). Andrew, can you please commit it and close the issue if it resolves the problem?
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 4.2
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-117) [Mac OS X 10.2.8] Missing header
guards in utility source files
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor updated STDCXX-117:
--------------------------------
Fix Version/s: 4.2
Affects Version/s: (was: 4.2)
> [Mac OS X 10.2.8] Missing header guards in utility source files
> ---------------------------------------------------------------
>
> Key: STDCXX-117
> URL: https://issues.apache.org/jira/browse/STDCXX-117
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Utilities
> Environment: Mac OS X 10.2.8/Darwin 6.8 with GCC 3.1
> Reporter: Andrew Black
> Assignee: Andrew Black
> Fix For: 4.2
>
> Attachments: utilguard.diff
>
>
> Several files used in the building of the utilities (util/aliases.cpp, util/charmap.cpp, util/charmap.h, util/locale.cpp) are missing guards on the inclusion of the langinfo.h and iconv.h headers. I will be ataching a patch for this shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.