You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/12/22 10:56:11 UTC
[GitHub] [nuttx] PetervdPerk-NXP opened a new pull request, #7958: S32K3XX PHY MII/MMD support and TJA1103 support
PetervdPerk-NXP opened a new pull request, #7958:
URL: https://github.com/apache/nuttx/pull/7958
## Summary
S32K3XX EMAC Driver add MDIO and TJA1103 Phy support
## Impact
Minimal
## Testing
Tested with netinit for phy link status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #7958: S32K3XX PHY MII/MMD support and TJA1103 support
Posted by GitBox <gi...@apache.org>.
davids5 commented on code in PR #7958:
URL: https://github.com/apache/nuttx/pull/7958#discussion_r1055396665
##########
arch/arm/src/s32k3xx/s32k3xx_flexcan.c:
##########
@@ -1639,7 +1639,7 @@ static int s32k3xx_txavail(struct net_driver_s *dev)
*
****************************************************************************/
-#ifdef CONFIG_NETDEV_CAN_BITRATE_IOCTL
+#ifdef CONFIG_NETDEV_IOCTL
Review Comment:
This file should be separate commit ot better yet a different PR
##########
arch/arm/src/s32k3xx/s32k3xx_flexcan.c:
##########
@@ -1639,7 +1639,7 @@ static int s32k3xx_txavail(struct net_driver_s *dev)
*
****************************************************************************/
-#ifdef CONFIG_NETDEV_CAN_BITRATE_IOCTL
+#ifdef CONFIG_NETDEV_IOCTL
Review Comment:
This file should be separate commit or better yet a different PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] PetervdPerk-NXP commented on a diff in pull request #7958: S32K3XX PHY MII/MMD support and TJA1103 support
Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP commented on code in PR #7958:
URL: https://github.com/apache/nuttx/pull/7958#discussion_r1055446571
##########
arch/arm/src/s32k3xx/s32k3xx_flexcan.c:
##########
@@ -1639,7 +1639,7 @@ static int s32k3xx_txavail(struct net_driver_s *dev)
*
****************************************************************************/
-#ifdef CONFIG_NETDEV_CAN_BITRATE_IOCTL
+#ifdef CONFIG_NETDEV_IOCTL
Review Comment:
I've split it up but it's still related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #7958: S32K3XX PHY MII/MMD support and TJA1103 support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7958:
URL: https://github.com/apache/nuttx/pull/7958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org