[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2646: ARTEMIS-2317 Reuse file buffer wrapper instances to reduce allocations

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #2646: ARTEMIS-2317 Reuse file buffer wrapper instances to reduce allocations
URL: https://github.com/apache/activemq-artemis/pull/2646#discussion_r278944886
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ##########
 @@ -119,12 +117,6 @@ public void setLiveCache(LivePageCache pageCache) {
       return messages;
    }
 
-   private static void decodeInto(ByteBuffer fileBuffer, int encodedSize, PagedMessageImpl msg) {
-      final ActiveMQBuffer wrappedBuffer = ActiveMQBuffers.wrappedBuffer(fileBuffer);
 
 Review comment:
   Yep! Now I just need to fix something on the wrapper indexes and it should be fine...I didn't expect to allocate so much garbage just for few instances :O
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services