You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ri...@apache.org on 2008/07/15 19:17:17 UTC
svn commit: r676982 - in /incubator/qpid/trunk/qpid/java: client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java common/src/main/java/log4j.properties

Author: ritchiem
Date: Tue Jul 15 10:17:16 2008
New Revision: 676982

URL: http://svn.apache.org/viewvc?rev=676982&view=rev
Log:
QPID-1177 : Added Protocol Level Debug logging. Uses a final static so should JIT out if disabled. To enable set -Damqj.protocol.logging.level=info

Modified:
    incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java
    incubator/qpid/trunk/qpid/java/common/src/main/java/log4j.properties

Modified: incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java?rev=676982&r1=676981&r2=676982&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java (original)
+++ incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java Tue Jul 15 10:17:16 2008
@@ -122,6 +122,8 @@
 {
     /** Used for debugging. */
     private static final Logger _logger = LoggerFactory.getLogger(AMQProtocolHandler.class);
+    private static final Logger _protocolLogger = LoggerFactory.getLogger("qpid.protocol");
+    private static final boolean PROTOCOL_DEBUG = (System.getProperty("amqj.protocol.logging.level") != null);
 
     /**
      * The connection that this protocol handler is associated with. There is a 1-1 mapping between connection
@@ -484,7 +486,12 @@
 
     public void messageReceived(IoSession session, Object message) throws Exception
     {
-        if (message instanceof AMQFrame)
+        if (PROTOCOL_DEBUG)
+        {
+            _protocolLogger.info("Recv:"+message);
+        }
+
+        if(message instanceof AMQFrame)
         {
             final boolean debug = _logger.isDebugEnabled();
             final long msgNumber = ++_messageReceivedCount;
@@ -565,6 +572,11 @@
 
     public void messageSent(IoSession session, Object message) throws Exception
     {
+        if (PROTOCOL_DEBUG)
+        {
+            _protocolLogger.info("Send:"+message);
+        }
+        
         final long sentMessages = _messagesOut++;
 
         final boolean debug = _logger.isDebugEnabled();

Modified: incubator/qpid/trunk/qpid/java/common/src/main/java/log4j.properties
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/common/src/main/java/log4j.properties?rev=676982&r1=676981&r2=676982&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/common/src/main/java/log4j.properties (original)
+++ incubator/qpid/trunk/qpid/java/common/src/main/java/log4j.properties Tue Jul 15 10:17:16 2008
@@ -19,6 +19,8 @@
 log4j.rootLogger=${root.logging.level}
 
 
+log4j.logger.qpid.protocol=${amqj.protocol.logging.level}, console
+log4j.additivity.qpid.protocol=false
 log4j.logger.org.apache.qpid=${amqj.logging.level}, console
 log4j.additivity.org.apache.qpid=false