You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Simeon Koptelov (JIRA)" <de...@tapestry.apache.org> on 2008/05/13 16:22:55 UTC
[jira] Created: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
GridColumns is using asset.toString() instead of asset.toClientURL()
--------------------------------------------------------------------
Key: TAPESTRY-2417
URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.12
Reporter: Simeon Koptelov
GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Semyon Koptelov (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Semyon Koptelov updated TAPESTRY-2417:
--------------------------------------
Fix Version/s: (was: 5.0.12)
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Semyon Koptelov
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Semyon Koptelov (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Semyon Koptelov updated TAPESTRY-2417:
--------------------------------------
Fix Version/s: 5.0.12
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Semyon Koptelov
> Fix For: 5.0.12
>
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Semyon Koptelov (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Semyon Koptelov resolved TAPESTRY-2417.
---------------------------------------
Resolution: Won't Fix
I'm stupid, sorry. Didn't read Asset javadoc. Shame on me.
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Semyon Koptelov
> Fix For: 5.0.12
>
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Semyon Koptelov (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Semyon Koptelov closed TAPESTRY-2417.
-------------------------------------
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Semyon Koptelov
> Fix For: 5.0.12
>
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Filip S. Adamsen (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596466#action_12596466 ]
Filip S. Adamsen commented on TAPESTRY-2417:
--------------------------------------------
You need to clear Fix Version/s since the issue wasn't fixed but merely closed.
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Semyon Koptelov
> Fix For: 5.0.12
>
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2417) GridColumns is using
asset.toString() instead of asset.toClientURL()
Posted by "Simeon Koptelov (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simeon Koptelov updated TAPESTRY-2417:
--------------------------------------
Attachment: gridcolumns-icon.patch
Patch for this issue
> GridColumns is using asset.toString() instead of asset.toClientURL()
> --------------------------------------------------------------------
>
> Key: TAPESTRY-2417
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2417
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.12
> Reporter: Simeon Koptelov
> Attachments: gridcolumns-icon.patch
>
>
> GridColumns.getIcon() should return String, not Asset because in expansion it uses toString() of Asset. It works now because icon assets are hard-coded and their classes return URL in toString(), but is wrong is general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org