You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/12 21:21:00 UTC

[jira] [Work logged] (GOBBLIN-1678) Refactor GaaS Flowgraph Monitor to be extensible

     [ https://issues.apache.org/jira/browse/GOBBLIN-1678?focusedWorklogId=800383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800383 ]

ASF GitHub Bot logged work on GOBBLIN-1678:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/22 21:20
            Start Date: 12/Aug/22 21:20
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3536:
URL: https://github.com/apache/gobblin/pull/3536

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1678
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
     The FlowGraphMonitor is tied to the implementation of being a Git-based service. Since we want to support file based flowgraphs, we should reuse as much logic as possible while maintaining the same interfaces.
     
     To achieve this, the PR treats the flowgraph monitor as a service, and has listeners which would be run by the service manager and needs to support a function to setActive(boolean). The rest of the flowgraph monitor would be registering listeners, to observe from an appropriate source (e.g. Git, Filesource), and the listeners would apply changes appropriately to the flowgraph based on the changes.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 800383)
    Remaining Estimate: 0h
            Time Spent: 10m

> Refactor GaaS Flowgraph Monitor to be extensible
> ------------------------------------------------
>
>                 Key: GOBBLIN-1678
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1678
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> To support new implementations of a flow graph monitor, which allows for live updating of a flowgraph, we should reuse as much implementation from the existing git flowgraph monitor as possible.
> The current flowgraph monitor has coupled logic to perform a lot of the adding node/edges which can be reused for a file based flowgraph.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)