[GitHub] [servicecomb-java-chassis] develpoerX commented on a change in pull request #2527: SCB-2319 when dowanload part is null, will throw NPE

[GitBox <gi...@apache.org>]

develpoerX commented on a change in pull request #2527:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2527#discussion_r700114077



##########
File path: foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java
##########
@@ -346,6 +346,12 @@ public void sendPart_openInputStreamFailed(@Mocked Part part)
     future.get();
   }
 
+  @Test
+  public void sendPart_testPartIsNull(@Mocked Part part) throws InterruptedException, ExecutionException {
+    CompletableFuture<Void> future1 = response.sendPart(null);
+    Assert.assertNull(future1.get());
+  }
+

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org