You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2015/08/10 09:05:27 UTC
Review Request 37285: solr conf files and changes to make it work with
upgraded titan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/
-----------------------------------------------------------
Review request for atlas and Shwetha GS.
Repository: atlas
Description
-------
changes for titan upgraded to solr 5
Diffs
-----
client/pom.xml d393b3a
pom.xml facd539
repository/pom.xml a2f8e08
src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
src/conf/solr/solr.xml PRE-CREATION
src/conf/solr/zoo.cfg PRE-CREATION
Diff: https://reviews.apache.org/r/37285/diff/
Testing
-------
All tests pass . No new tests added
Thanks,
Suma Shivaprasad
Re: Review Request 37285: solr conf files and changes to make it work
with upgraded titan
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/#review94722
-----------------------------------------------------------
Ship it!
Ship It!
- Shwetha GS
On Aug. 10, 2015, 11:16 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37285/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 11:16 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> changes for titan upgraded to solr 5
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37285/diff/
>
>
> Testing
> -------
>
> All tests pass . No new tests added
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 37285: solr conf files and changes to make it work
with upgraded titan
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 11:16 a.m.)
Review request for atlas and Shwetha GS.
Changes
-------
Fixed doc review comments
Repository: atlas
Description
-------
changes for titan upgraded to solr 5
Diffs (updated)
-----
client/pom.xml d393b3a
docs/src/site/twiki/InstallationSteps.twiki 0391c2d
pom.xml facd539
repository/pom.xml a2f8e08
src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
Diff: https://reviews.apache.org/r/37285/diff/
Testing
-------
All tests pass . No new tests added
Thanks,
Suma Shivaprasad
Re: Review Request 37285: solr conf files and changes to make it work
with upgraded titan
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/#review94720
-----------------------------------------------------------
docs/src/site/twiki/InstallationSteps.twiki (line 131)
<https://reviews.apache.org/r/37285/#comment149338>
in - should be is
docs/src/site/twiki/InstallationSteps.twiki (line 137)
<https://reviews.apache.org/r/37285/#comment149333>
Mention of namenode not required. You can just say, either re-use zookeeper or set-up new one
docs/src/site/twiki/InstallationSteps.twiki (line 146)
<https://reviews.apache.org/r/37285/#comment149334>
that you have in the cluster - change to 'that you have in the solr cluster'
docs/src/site/twiki/InstallationSteps.twiki (line 147)
<https://reviews.apache.org/r/37285/#comment149335>
Remove : at the end?
docs/src/site/twiki/InstallationSteps.twiki (line 149)
<https://reviews.apache.org/r/37285/#comment149336>
point to the properties file - <atlas package>/conf/application.properties
docs/src/site/twiki/InstallationSteps.twiki (line 150)
<https://reviews.apache.org/r/37285/#comment149337>
you can also add link to titan solr config page for more configs
Some comments on documnetation
- Shwetha GS
On Aug. 10, 2015, 9:12 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37285/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 9:12 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> changes for titan upgraded to solr 5
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
> src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
> src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37285/diff/
>
>
> Testing
> -------
>
> All tests pass . No new tests added
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 37285: solr conf files and changes to make it work
with upgraded titan
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 9:12 a.m.)
Review request for atlas and Shwetha GS.
Changes
-------
Fixed review comments
Repository: atlas
Description
-------
changes for titan upgraded to solr 5
Diffs (updated)
-----
client/pom.xml d393b3a
docs/src/site/twiki/InstallationSteps.twiki 0391c2d
pom.xml facd539
repository/pom.xml a2f8e08
src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
Diff: https://reviews.apache.org/r/37285/diff/
Testing
-------
All tests pass . No new tests added
Thanks,
Suma Shivaprasad
Re: Review Request 37285: solr conf files and changes to make it work
with upgraded titan
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37285/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 8:57 a.m.)
Review request for atlas and Shwetha GS.
Changes
-------
Added documentation for solr installation
Repository: atlas
Description
-------
changes for titan upgraded to solr 5
Diffs (updated)
-----
client/pom.xml d393b3a
docs/src/site/twiki/InstallationSteps.twiki 0391c2d
pom.xml facd539
repository/pom.xml a2f8e08
src/conf/solr/atlasConfig/conf/currency.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/protwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/schema.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/solrconfig.xml PRE-CREATION
src/conf/solr/atlasConfig/conf/stopwords.txt PRE-CREATION
src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION
src/conf/solr/solr.xml PRE-CREATION
src/conf/solr/zoo.cfg PRE-CREATION
Diff: https://reviews.apache.org/r/37285/diff/
Testing
-------
All tests pass . No new tests added
Thanks,
Suma Shivaprasad