You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/19 08:57:17 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4848: remove some ignored sql cases

tristaZero opened a new pull request #4848: remove some ignored sql cases
URL: https://github.com/apache/incubator-shardingsphere/pull/4848
 
 
   Ref #4696 .
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero removed a comment on issue #4848: Add parsing result for test case

Posted by GitBox <gi...@apache.org>.

tristaZero removed a comment on issue #4848: Add parsing result for test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4848#issuecomment-601093524

### How to find the targets to be fixed?
1. Open class `SQLParserParameterizedTest` and delete the following lines,
```
// TODO Correct for new parser, please remove them after using new parser
sqlCases.add("insert_on_duplicate_key_update_with_base64_aes_encrypt");
sqlCases.add("insert_with_one_auto_increment_column");
sqlCases.add("insert_on_duplicate_key_update_with_complicated_expression");
sqlCases.add("insert_without_columns_and_with_generate_key_column");
sqlCases.add("insert_without_columns_and_without_generate_key_column");
sqlCases.add("insert_without_columns_with_all_placeholders");
```
2. run `SQLParserParameterizedTest`
3. All the SQL cases which have the error assertion results are our targets to be fixed.

### How to fix the above assertion results?
1. Look at the exception log and find the corresponding `SQL Case ID` and `SQL`.
2. Find out the `parsing result` of this `SQL Case ID` in `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml`
3. Calculate the correct `start-index` and `stop-index` of `parameter-marker-expression` segment (i.e., `?`) of this `SQL`.
4. Add the calculated `start-index` and `stop-index` labels of `parameter-marker-expression` segment to `parsing result` of this `SQL Case ID`, like
```
<parameter-marker-expression value="2" start-index="10" stop-index="11" />
```
5. Run `SQLParserParameterizedTest` again to check whether this `SQL Case ID` does not stay in the list of `SQL` with `bad assertion result`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4848: remove some ignored sql cases

Posted by GitBox <gi...@apache.org>.

tristaZero commented on issue #4848: remove some ignored sql cases
URL: https://github.com/apache/incubator-shardingsphere/pull/4848#issuecomment-601064363
 
 
   Ref #4696 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4848: Add parsing result for test case

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #4848: Add parsing result for test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4848
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4848: Add parsing result for test case

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4848: Add parsing result for test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4848#issuecomment-601093861
 
 
   ## Pull Request Test Coverage Report for [Build 10402](https://coveralls.io/builds/29467182)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **59.636%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29467182/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29467182/badge)](https://coveralls.io/builds/29467182) |
   | :-- | --: |
   | Change from base [Build 1119](https://coveralls.io/builds/29466175): |  -0.005% |
   | Covered Lines: | 12464 |
   | Relevant Lines: | 20900 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4848: Add parsing result for test case

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #4848: Add parsing result for test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4848#issuecomment-601093861
 
 
   ## Pull Request Test Coverage Report for [Build 2166](https://coveralls.io/builds/29466997)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.07%**) to **59.713%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29466997/badge)](https://coveralls.io/builds/29466997) |
   | :-- | --: |
   | Change from base [Build 1119](https://coveralls.io/builds/29466175): |  0.07% |
   | Covered Lines: | 12480 |
   | Relevant Lines: | 20900 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4848: Add parsing result for test case

Posted by GitBox <gi...@apache.org>.

tristaZero commented on issue #4848: Add parsing result for test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4848#issuecomment-601093524

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services