[GitHub] [flink] Tartarus0zm commented on a diff in pull request #19714: [FLINK-27603][hive] Hive dialect supports 'reload function'

[GitBox <gi...@apache.org>]

Tartarus0zm commented on code in PR #19714:
URL: https://github.com/apache/flink/pull/19714#discussion_r894140022


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParser.java:
##########
@@ -218,7 +217,11 @@ private List<Operation> processCmd(
             // parse statement to get AST
             final HiveParserASTNode node = HiveASTParseUtils.parse(cmd, context);
             Operation operation;
-            if (DDL_NODES.contains(node.getType())) {
+            if (node.getType() == HiveASTParser.TOK_RELOADFUNCTION) {
+                // call  reload function
+                hiveCatalog.reloadFunctions();

Review Comment:
   Calling HiveCatalog#reloadFunctions directly in Parser looks very hack.
   If it is as said in JIRA, is there no need to call it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org