[jira] [Commented] (THRIFT-1512) Thrift socket support for Windows XP

["Roger Meier (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200827#comment-13200827 ] 

Roger Meier commented on THRIFT-1512:
-------------------------------------

I had the following issues:
{noformat}
Thrift_XP_skt.patch:8: trailing whitespace.
Windows version compatibility
Thrift_XP_skt.patch:9: trailing whitespace.
=============================
Thrift_XP_skt.patch:10: trailing whitespace.
The Thrift library targets Windows XP for broadest compatbility. A notable
Thrift_XP_skt.patch:11: trailing whitespace.
difference is in the Windows-specific implementation of the socket poll
Thrift_XP_skt.patch:12: trailing whitespace.
function. To target Vista, Win7 or other versions, comment out the line
error: patch failed: lib/cpp/README_WINDOWS:75
error: lib/cpp/README_WINDOWS: patch does not apply
error: patch failed: lib/cpp/src/windows/TargetVersion.h:28
error: lib/cpp/src/windows/TargetVersion.h: patch does not apply
error: patch failed: lib/cpp/src/windows/config.h:78
error: lib/cpp/src/windows/config.h: patch does not apply
error: patch failed: lib/cpp/src/windows/force_inc.h:18
error: lib/cpp/src/windows/force_inc.h: patch does not apply
{noformat}

Peace, could you please rebase this patch to trunk?

-roger
                
> Thrift socket support for Windows XP
> ------------------------------------
>
>                 Key: THRIFT-1512
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1512
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.8
>         Environment: Windows XP, Visual Studio
>            Reporter: Peace C
>              Labels: msvc, thrift,, windows, xp
>             Fix For: 0.9
>
>         Attachments: Thrift_XP_skt.patch
>
>
> This is a follow-up patch to THRIFT-1490. The previous code would never follow the Windows XP path (WINVER 0x0501). At least that appears to be the case since poll_win32() was incomplete and not functional. Windows' version of select() does not set the revents field so FD_ISSET is used to determine how to manually set it.  I've tested this on a sample project and it's working as expected. config.h is now targeting XP for wider compatibility. If this isn't desired or you don't trust the new code, comment out the two #define lines toward the top and it will revert to targeting Vista/Win7.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira