You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/19 23:45:55 UTC
[GitHub] [airflow] dbarrundiag opened a new pull request, #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
dbarrundiag opened a new pull request, #25171:
URL: https://github.com/apache/airflow/pull/25171
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR closes: #25138.
Changes:
* New attribute of `message_group_id` in `SQSPublishOperator` to support sending that value to the AWS APIs when the SQS queue is a FIFO queue.
* 2 new test cases
* If the parameter `MessageGroupId` **is not** provided and the Operator attempts to send a message to a FIFO queue, the Operator will **fail**.
* If the parameter `MessageGroupId` **is** provided and the Operator attempts to send a message to a FIFO queue, the Operator should **succeed** and the `MessageGroupId` should come in the response.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25171:
URL: https://github.com/apache/airflow/pull/25171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25171:
URL: https://github.com/apache/airflow/pull/25171#issuecomment-1191694389
> @potiuk no i believe i am not able to re-run it, unless i am completely missing something
Yeah. I've learned today that partial re-run from https://github.blog/2022-03-16-save-time-partial-re-runs-github-actions/ is only available to maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dbarrundiag commented on pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
dbarrundiag commented on PR #25171:
URL: https://github.com/apache/airflow/pull/25171#issuecomment-1189656077
CC: @eladkal - closed #25170 in favor of this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25171:
URL: https://github.com/apache/airflow/pull/25171#issuecomment-1190238422
Just re-run - it.. Question @dbarrundiag Do you have the ability to re-run yourself (top rigth when you go to details?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dbarrundiag commented on pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
dbarrundiag commented on PR #25171:
URL: https://github.com/apache/airflow/pull/25171#issuecomment-1190263323
> Just re-run - it.. Question @dbarrundiag Do you have the ability to re-run yourself (top rigth when you go to details?)
<img width="1444" alt="Screen Shot 2022-07-20 at 7 04 33 AM" src="https://user-images.githubusercontent.com/12784827/179989170-bb2ac255-9208-45e7-8f8a-fb2cc5c7320d.png">
@potiuk no i believe i am not able to re-run it, unless i am completely missing something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dbarrundiag commented on pull request #25171: SQSPublishOperator should allow sending messages to a FIFO Queue
Posted by GitBox <gi...@apache.org>.
dbarrundiag commented on PR #25171:
URL: https://github.com/apache/airflow/pull/25171#issuecomment-1189828924
@eladkal @potiuk - do you guys know if we can "rerun" these Static checks.
From what I can tell Github Actions failed on the `run-shellcheck` check:
<img width="687" alt="Screen Shot 2022-07-19 at 10 54 37 PM" src="https://user-images.githubusercontent.com/12784827/179900012-3fa41966-34c7-4a58-b992-f5e1bc2cad74.png">
however i think this might have been a transient issue because the checks are passing locally:
<img width="981" alt="Screen Shot 2022-07-19 at 10 51 43 PM" src="https://user-images.githubusercontent.com/12784827/179899935-462ad621-cbd3-4aea-b347-000cbaca664b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org