You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/12/06 23:05:38 UTC
[GitHub] codecov-io commented on issue #3588: Add the bloom filter to
equals() and hashCode() in IndexingConfig
codecov-io commented on issue #3588: Add the bloom filter to equals() and hashCode() in IndexingConfig
URL: https://github.com/apache/incubator-pinot/pull/3588#issuecomment-445062928
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=h1) Report
> Merging [#3588](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ea628a93cc1bb7d7b0034e40460ba8b8e05bc709?src=pr&el=desc) will **increase** coverage by `11.92%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3588 +/- ##
=============================================
+ Coverage 58.91% 70.83% +11.92%
Complexity 4 4
=============================================
Files 1157 1009 -148
Lines 58631 46254 -12377
Branches 8124 6209 -1915
=============================================
- Hits 34543 32766 -1777
+ Misses 21686 11327 -10359
+ Partials 2402 2161 -241
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...m/linkedin/pinot/common/config/IndexingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9jb25maWcvSW5kZXhpbmdDb25maWcuamF2YQ==) | `54.28% <0%> (-1.06%)` | `0 <0> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0VtcHR5QnJva2VyT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.81% <0%> (-5.46%)` | `0% <0%> (ø)` | |
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `68.75% <0%> (-5.21%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `71.11% <0%> (-4.45%)` | `0% <0%> (ø)` | |
| [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `73.07% <0%> (-3.85%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/BitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL0JpdG1hcERvY0lkSXRlcmF0b3IuamF2YQ==) | `60.71% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [...inot/transport/netty/NettyTCPClientConnection.java](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L3RyYW5zcG9ydC9uZXR0eS9OZXR0eVRDUENsaWVudENvbm5lY3Rpb24uamF2YQ==) | `82.31% <0%> (-1.37%)` | `0% <0%> (ø)` | |
| ... and [164 more](https://codecov.io/gh/apache/incubator-pinot/pull/3588/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=footer). Last update [ea628a9...63f92b8](https://codecov.io/gh/apache/incubator-pinot/pull/3588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org