You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ea...@apache.org on 2019/06/07 04:12:43 UTC

[commons-numbers] 02/02: [numbers] support JUnit 5 tests

This is an automated email from the ASF dual-hosted git repository.

eax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 6bcc6d9a16bea265243f68b298713d10abb09224
Author: Eitan Adler <li...@eitanadler.com>
AuthorDate: Wed Jun 5 02:34:25 2019 -0700

    [numbers] support JUnit 5 tests
---
 pom.xml | 34 +++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index 8ff0a23..b3d5dff 100644
--- a/pom.xml
+++ b/pom.xml
@@ -96,14 +96,30 @@
         <type>test-jar</type>
         <scope>test</scope>
       </dependency>
+      <dependency>
+        <groupId>org.junit</groupId>
+        <artifactId>junit-bom</artifactId>
+        <version>${numbers.junit.bom.version}</version>
+        <scope>import</scope>
+        <type>pom</type>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 
   <dependencies>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>4.12</version>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-engine</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.platform</groupId>
+      <artifactId>junit-platform-runner</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.vintage</groupId>
+      <artifactId>junit-vintage-engine</artifactId>
       <scope>test</scope>
     </dependency>
   </dependencies>
@@ -133,6 +149,7 @@
     <numbers.pmd.version>3.9.0</numbers.pmd.version>
     <numbers.checkstyle.version>3.0.0</numbers.checkstyle.version>
     <numbers.mathjax.version>2.7.2</numbers.mathjax.version>
+    <numbers.junit.bom.version>5.4.2</numbers.junit.bom.version>
     <!-- Workaround to avoid duplicating config files. -->
     <numbers.parent.dir>${basedir}</numbers.parent.dir>
 
@@ -188,13 +205,12 @@
       </plugin>
 
       <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
-        <configuration>
-          <!-- Fix for OpenJDK 8 now validating class-path attributes in Jar manifests. -->
-          <!-- See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912333#63 -->
-          <useSystemClassLoader>false</useSystemClassLoader>
-        </configuration>
+        <version>2.22.0</version>
+      </plugin>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <version>2.22.0</version>
       </plugin>
       <plugin>
         <artifactId>maven-assembly-plugin</artifactId>